Skip to content

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Aug 1, 2025

Prerequisite PRs


Description of changes:

Integration test for Apache HTTPD.

Call-outs:

  • Tests relating to TLS renegotiation are excluded b/c AWS-LC disables TLS renegotiation by default
  • We do not build "mod_md", so associated tests are disabled.

Testing:

  • All httpd tests are run (except those called out above).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth force-pushed the verify-result branch 3 times, most recently from 4da1db7 to ec81013 Compare August 4, 2025 11:36
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.23%. Comparing base (d966806) to head (3a637b5).

Files with missing lines Patch % Lines
ssl/ssl_client_hello_test.cc 84.21% 11 Missing and 1 partial ⚠️
ssl/ssl_lib.cc 79.31% 12 Missing ⚠️
ssl/ssl_transfer_asn1.cc 62.50% 3 Missing ⚠️
ssl/handshake.cc 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2591      +/-   ##
==========================================
- Coverage   78.68%   76.23%   -2.46%     
==========================================
  Files         645      645              
  Lines      110738   110922     +184     
  Branches    15656    15665       +9     
==========================================
- Hits        87132    84557    -2575     
- Misses      22915    25626    +2711     
- Partials      691      739      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants