Skip to content

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Jan 5, 2018

This PR replaces the SDK's dependency on crypto-browserify with direct dependencies on the portions of the crypto API on which the SDK depends, namely createHash and createHmac. As a result, we are no longer pulling in any form of CSPRNG or AES implementation, which should reduce the size of the SDK's bundle somewhat.

Resolves #1602

@codecov-io
Copy link

codecov-io commented Jan 5, 2018

Codecov Report

Merging #1857 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1857   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files         214      214           
  Lines        6933     6933           
  Branches     1364     1364           
=======================================
  Hits         6650     6650           
  Misses        283      283

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0e76a...ca93119. Read the comment docs.

@jeskew jeskew merged commit 0638060 into aws:master Jan 5, 2018
@jeskew jeskew deleted the feature/only-pull-in-subset-of-crypto-browserify branch January 5, 2018 22:23
@KurtPattyn
Copy link

Great!

@WChoy
Copy link

WChoy commented Jan 12, 2018

Breaking the crypto in ReactNative and Browser. "Unable to resolve module 'stream'."

create-hmac and create-hash use a hash-base module. That does a
"var Transform = require('stream').Transform". That was defined in node.js core (NOT a standard JS function, see https://nodejs.org/api/stream.html#stream_new_stream_transform_options)

Reproducible in https://github.com/awslabs/aws-mobile-react-native-starter

@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerability in crypto-browserify
5 participants