-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Replace dependency on create-hash and create-hmac with bundled hash implementations #1880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
281b7c7
to
813a660
Compare
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
==========================================
+ Coverage 95.91% 95.97% +0.05%
==========================================
Files 214 219 +5
Lines 6933 7298 +365
Branches 1364 1398 +34
==========================================
+ Hits 6650 7004 +354
- Misses 283 294 +11
Continue to review full report at Codecov.
|
165a4ae
to
8c2ee5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I tested this branch with react-native on iOS and verified that my application could load, the S3/V4 signers work, and tested several operations.
The integration tests run without issue in IE, Edge, Chrome, and Firefox on my computer, though there is an unrelated failure running the unit tests in IE and Edge. I saw the same error with master, with this PR, and with version 2.177.0 (the last SDK release to include a full version of |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This PR is a follow-up to #1857.
create-hash
andcreate-hmac
bring in a transitive dependency that some customers have reported as causing build problems (e.g., #1857 (comment)). This passes the browser and react-native tests locally using karma + phantomjs, but it's worth trying in a few different browsers.