Using GH actions for unit tests in place of travis #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-xray-sdk-python into gh_actions_unit_tests
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
=======================================
Coverage 79.29% 79.29%
=======================================
Files 80 80
Lines 3159 3159
=======================================
Hits 2505 2505
Misses 654 654 Continue to review full report at Codecov.
|
|
We'll probably need to remove the Travis application too from the repo. |
|
Closing this PR in favor of a new one: #322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing our CI to run unit tests through Github actions instead of Travis. Travis has been a little flaky in the past with jobs hanging to report back the status due this known issue.
I played with a couple of options for this workflow and both have some caveats.
First, I tried using the
tox -e pycommand in the workflow to run tox tests as mentioned in the official GH docs. But looks like it only works if you have simple tox environments like py27, py34, py 35 and so on, and not if you have environment like py27-default, py38-django22 which is what we have here.Then I tried this seemingly popular tox plugin
tox-gh-actionswhich works with any tox environment. This works for us and I did some trial runs here. The only problem with this plugin is that its not available for Python3.4 so we won't be able to run test for thepy34-defaultenvironment.I'm okay with holding out in merging this PR until our next major version where we plan to deprecate python2.7 and python3.4.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.