-
Notifications
You must be signed in to change notification settings - Fork 144
Improving CI for running tests #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change! It's already so so much better, I'm super excited for it 😄
Mostly I have nit comments and suggestions, please let me know what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feedback. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! Finally CI again! 🎉
* Fixing CI * just keep master branch in the workflow * Refactors based on PR comments * tox accepts only 1 dep per line * fixing some deps * fixing some deps * fixing some deps * pinning pytest-aiohttp dep version
…ap reports * add patch for Django 4.x compatibility * remove patch for aiobotocore 2.x compatibility - fixed upstream aws/aws-xray-sdk-python#322 git-svn-id: file:///srv/repos/svn-community/svn@1243612 9fca08f4-af9d-4005-b8df-a31f2cc04f65
…ap reports * add patch for Django 4.x compatibility * remove patch for aiobotocore 2.x compatibility - fixed upstream aws/aws-xray-sdk-python#322 git-svn-id: file:///srv/repos/svn-community/svn@1243612 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Issue:
The Python SDK CI which used Travis had been having issues like builds not triggering or getting stuck, etc for a while.
Description of changes:
master
tox.ini
to simplify the structure of test suite. Now the tests are split into "core" which tests the main core logic of the SDK, and "ext" which tests all the library instrumentations. Both combinations are run for a set of different python versions (2.7 to 3.9)json.loads()
to UTF-8 because python 3.4 and 3.5 will break the API with following error. Python 3.6+ do this automatically but being explicit doesn't hurt here._server_version
attribute on the connection object is not present and the assertion fordatabase_version
fails.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.