Skip to content

Safety comments in MultiThreadedExecutor are incorrect #7833

@joseph-gio

Description

@joseph-gio

Both places where System::run_unsafe is called in MultiThreadedExecutor still have placeholder safety comments. They simply state that the safety invariants are upheld, without making any attempt to explain how they are upheld.

// SAFETY: access is compatible

// SAFETY: caller ensures system access is compatible

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ECSEntities, components, systems, and eventsP-UnsoundA bug that results in undefined compiler behavior

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions