[Merged by Bors] - Prepare crevice for vendored release #3394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Rendering
bjorn3
reviewed
Dec 19, 2021
mockersf
force-pushed
the
unique-crevice-entry
branch
from
7326bc0 to
f79700a
Compare
|
Great work! In general this looks good to me. I think the readme should cover the following topics (in this order):
I think we should leave attributions as they are for now, with the exception of the repo link, which should point to the bevy repo. |
cart
reviewed
Dec 20, 2021
|
I updated the readme 👍 |
|
Ooh two compiler panics in CI, fancy! |
|
rust nightly ICE probably related to one of rust-lang/rust#92187 rust-lang/rust#92163 and could be fixed by rust-lang/rust#92175 |
MinerSebas
suggested changes
Dec 23, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 23, 2021
# Objective - Our crevice is still called "crevice", which we can't use for a release - Users would need to use our "crevice" directly to be able to use the derive macro ## Solution - Rename crevice to bevy_crevice, and crevice-derive to bevy-crevice-derive - Re-export it from bevy_render, and use it from bevy_render everywhere - Fix derive macro to work either from bevy_render, from bevy_crevice, or from bevy ## Remaining - It is currently re-exported as `bevy::render::bevy_crevice`, is it the path we want? - After a brief suggestion to Cart, I changed the version to follow Bevy version instead of crevice, do we want that? - Crevice README.md need to be updated - in the `Cargo.toml`, there are a few things to change. How do we want to change them? How do we keep attributions to original Crevice? ``` authors = ["Lucien Greathouse <[email protected]>"] documentation = "https://docs.rs/crevice" homepage = "https://github.com/LPGhatguy/crevice" repository = "https://github.com/LPGhatguy/crevice" ``` Co-authored-by: François <[email protected]> Co-authored-by: Carter Anderson <[email protected]>
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Remaining
bevy::render::bevy_crevice, is it the path we want?Cargo.toml, there are a few things to change. How do we want to change them? How do we keep attributions to original Crevice?