[Merged by Bors] - Cleanup many sprites stress tests #7436
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopap
added
C-Docs
tim-blackbird
approved these changes
Jan 31, 2023
|
Are there no longer plans for adding 2d frustum culling? If I'm remembering right, we only briefly had a buggy implementation (not sure if it was merged actually), but many_sprites was added to test it. There's a stalled out PR here: #3944. It seems potentially worth doing. Could the text be tweaked slightly so that it doesn't imply that this is something we're already doing? |
nicopap
force-pushed
the
do-not-lie-about-culling
branch
from
d08683f to
6433744
Compare
nicopap
changed the title
Since the new renderer, no frustum culling is applied to 2d components (be it Sprite or Mesh2d), the stress_tests docs is therefore misleading and should be updated. Furthermore, the `many_animated_sprites` example, unlike `many_sprites` kept vsync enabled, making the stress test less useful than it could be. We now disable vsync for `many_animated_sprites`. Also, `many_animated_sprites` didn't have the stress_tests warning message, instead, it had a paragraph in the module doc. I replaced the module doc paragraph by the warning message, to be more in line with other examples.
nicopap
force-pushed
the
do-not-lie-about-culling
branch
from
6433744 to
e199d5c
Compare
alice-i-cecile
approved these changes
Feb 1, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
@nicopap CI appears to be failing due to a broken import. Once that's fixed, I'm happy to merge this. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
Since the new renderer, no frustum culling is applied to 2d components (be it Sprite or Mesh2d), the stress_tests docs is therefore misleading and should be updated. Furthermore, the `many_animated_sprites` example, unlike `many_sprites` kept vsync enabled, making the stress test less useful than it could be. We now disable vsync for `many_animated_sprites`. Also, `many_animated_sprites` didn't have the stress_tests warning message, instead, it had a paragraph in the module doc. I replaced the module doc paragraph by the warning message, to be more in line with other examples. ## Solution - Remove the paragraph about frustum culling in the `many_sprites` and `many_animated_sprites` stress tests
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the new renderer, no frustum culling is applied to 2d components
(be it Sprite or Mesh2d), the stress_tests docs is therefore misleading
and should be updated.
Furthermore, the
many_animated_spritesexample, unlikemany_spriteskept vsync enabled, making the stress test less useful than it could be.
We now disable vsync for
many_animated_sprites.Also,
many_animated_spritesdidn't have the stress_tests warningmessage, instead, it had a paragraph in the module doc. I replaced the
module doc paragraph by the warning message, to be more in line with
other examples.
Solution
many_spritesand
many_animated_spritesstress tests