Skip to content

Add OnPreUpdate and OnPostUpdate #7673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add OnPreUpdate and OnPostUpdate #7673

wants to merge 2 commits into from

Conversation

lewiszlw
Copy link
Member

Objective

  • add more Onxxx helper.

Solution

  • Add OnPreUpdate and OnPostUpdate

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use X-Controversial There is active debate or serious implications around merging this PR labels Feb 14, 2023
@alice-i-cecile
Copy link
Member

I think that these are specific enough and easy enough to create that I would prefer end users do this manually when they need it. OnPreUpdate is particularly odd, since it occurs before the default state transitions.

@lewiszlw
Copy link
Member Author

Pr just for feedback. Seems we'd like to remove OnUpdate from cart's comment #7676 (comment) . Closing.

@lewiszlw lewiszlw closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewiszlw @alice-i-cecile