Manually implement common traits for EventId
#8529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
mockersf
reviewed
May 2, 2023
mockersf
added
A-ECS
# Objective Fixes bevyengine#8528 ## Solution Manually implement `PartialEq`, `Eq`, `PartialOrd`, `Ord`, and `Hash` for `bevy_ecs::event::EventId`. These new implementations do not rely on the `Event` implementing the same traits allowing `EventId` to be used in more cases.
mockersf
approved these changes
May 4, 2023
alice-i-cecile
approved these changes
May 4, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
MrGVSV
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #8528
Solution
Manually implement
PartialEq,Eq,PartialOrd,Ord, andHashforbevy_ecs::event::EventId. These new implementations do not rely on theEventimplementing the same traits allowingEventIdto be used in more cases.