Skip to content

Conversation

KatherineInCode
Copy link
Contributor

@KatherineInCode KatherineInCode commented Oct 2, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26064

📔 Objective

This moves BitwardenTextField to BitwardenKit, as part of a broader effort to move our various components into BitwardenKit. This also updates the component in BWA.

📸 Screenshots

Before After
Simulator Screenshot - iPhone 17 Pro - 2025-10-02 at 08 48 23 Simulator Screenshot - iPhone 17 Pro - 2025-10-02 at 08 50 37

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode added the hold This shouldn't be merged yet label Oct 2, 2025
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Logo
Checkmarx One – Scan Summary & Detailsc46e28ab-86fd-4de8-b1b6-b17f01b964bb

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.78%. Comparing base (277efe6) to head (482a214).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
- Coverage   81.32%   75.78%   -5.55%     
==========================================
  Files         832     1019     +187     
  Lines       52457    62068    +9611     
==========================================
+ Hits        42663    47037    +4374     
- Misses       9794    15031    +5237     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from pm-26064/appearance to main October 6, 2025 13:05
@KatherineInCode KatherineInCode marked this pull request as ready for review October 6, 2025 13:05
@KatherineInCode KatherineInCode requested review from matt-livefront and a team as code owners October 6, 2025 13:05
@KatherineInCode KatherineInCode removed the hold This shouldn't be merged yet label Oct 6, 2025
@KatherineInCode KatherineInCode merged commit fbbb2a2 into main Oct 6, 2025
14 of 16 checks passed
@KatherineInCode KatherineInCode deleted the pm-26064/bitwarden-text-field branch October 6, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants