Skip to content

[PM-26064] Move BitwardenTextField to BitwardenKit #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 6, 2025
Merged

[PM-26064] Move BitwardenTextField to BitwardenKit #2010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d6e6bb8
Move Appearance wholesale
KatherineInCode Sep 30, 2025
d6803b0
Get to build with PM
KatherineInCode Sep 30, 2025
f8d07eb
Get to build on BWA
KatherineInCode Oct 1, 2025
9588ed2
Merge branch 'main' into pm-26064/appearance
KatherineInCode Oct 1, 2025
8eb4b95
Move text field
KatherineInCode Oct 1, 2025
e0e2f3b
Remove textfield from BWA
KatherineInCode Oct 2, 2025
cd30aad
Fix tests
KatherineInCode Oct 2, 2025
482a214
Merge branch 'main' into pm-26064/bitwarden-text-field
KatherineInCode Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
263 changes: 0 additions & 263 deletions AuthenticatorShared/UI/Platform/Application/Views/BitwardenTextField.swift
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions AuthenticatorShared/UI/Platform/Application/Views/FormFields/FormTextFieldView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import BitwardenKit
import SwiftUI

// MARK: - FormTextField
Expand Down
1 change: 1 addition & 0 deletions AuthenticatorShared/UI/Platform/Application/Views/SectionView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import BitwardenKit
import BitwardenResources
import SwiftUI

Expand Down
9 changes: 4 additions & 5 deletions ...m/Application/Views/AccessoryButton.swift → ...m/Application/Views/AccessoryButton.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import BitwardenKit
import BitwardenResources
import SwiftUI

/// A view that displays a button for use as an accessory to a field.
///
struct AccessoryButton: View {
public struct AccessoryButton: View {
// MARK: Types

/// A type that wraps a synchrounous or asynchrounous block that is executed by this button.
Expand All @@ -31,7 +30,7 @@ struct AccessoryButton: View {
/// The image to display in the button.
var asset: SharedImageAsset

var body: some View {
public var body: some View {
switch action {
case let .async(action):
AsyncButton(action: action) {
Expand Down Expand Up @@ -64,7 +63,7 @@ struct AccessoryButton: View {
/// - accessibilityLabel: The accessibility label of the button.
/// - action: The action to perform when the user triggers the button.
///
init(asset: SharedImageAsset,
public init(asset: SharedImageAsset,
accessibilityLabel: String,
accessibilityIdentifier: String = "",
action: @escaping () -> Void) {
Expand All @@ -83,7 +82,7 @@ struct AccessoryButton: View {
/// - accessibilityIdentifier: The accessibility identifier of the button.
/// - action: The action to perform when the user triggers the button.
///
init(asset: SharedImageAsset,
public init(asset: SharedImageAsset,
accessibilityLabel: String,
accessibilityIdentifier: String = "",
action: @escaping () async -> Void) {
Expand Down
8 changes: 4 additions & 4 deletions ...on/Views/BitwardenFloatingTextLabel.swift → ...on/Views/BitwardenFloatingTextLabel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import SwiftUI
/// contains a value. At that point, the text label will float up above the input field. This is
/// primarily meant to wrap a text field or view.
///
struct BitwardenFloatingTextLabel<Content: View, TrailingContent: View>: View {
public struct BitwardenFloatingTextLabel<Content: View, TrailingContent: View>: View {
// MARK: Properties

/// The primary content containing the text input field for the label.
Expand All @@ -31,7 +31,7 @@ struct BitwardenFloatingTextLabel<Content: View, TrailingContent: View>: View {

// MARK: View

var body: some View {
public var body: some View {
HStack(spacing: 8) {
ZStack(alignment: showPlaceholder ? .leading : .topLeading) {
// The placeholder and title text which is vertically centered in the view when the
Expand Down Expand Up @@ -77,7 +77,7 @@ struct BitwardenFloatingTextLabel<Content: View, TrailingContent: View>: View {
/// - trailingContent: Optional trailing content to display on the trailing edge of the label
/// and text input field.
///
init(
public init(
title: String?,
isTextFieldDisabled: Bool = false,
showPlaceholder: Bool,
Expand All @@ -100,7 +100,7 @@ struct BitwardenFloatingTextLabel<Content: View, TrailingContent: View>: View {
/// the field.
/// - content: The primary content containing the text input field for the label.
///
init(
public init(
title: String?,
isTextFieldDisabled: Bool = false,
showPlaceholder: Bool,
Expand Down
Loading