dont close new opened tabs #844

seanmcguire12 · 2025-06-27T01:09:19Z

why

when a new tab is opened, we call page.goto() with the URL of the new tab, and immediately close the old tab
this is problematic, because on some websites you are required to keep the old tab open in order to continue browsing in the new tab
this PR removes that behaviour: we no longer close tabs implicitly

what changed

added a live page proxy in index.ts which always points to the focused page/tab
added a listener in StagehandContext.ts which listens for new pages, and initializes them as Stagehand pages
- this means that you can call act/extract/observe on all open pages, even if they are not the focused page
preserved expected behaviour when users define const page = stagehand.page and then use page throughout their code, they expect page to always point to the "focused" page

test plan

added two new act evals that open & close tabs
run act, regression and combination evals

changeset-bot · 2025-06-27T01:09:23Z

🦋 Changeset detected

Latest commit: 5ae360d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lib/StagehandContext.ts

greptile-apps

PR Summary

Major update to tab management in Stagehand that stops automatically closing new tabs, essential for websites requiring original tabs to remain open during navigation.

Added live page proxy in lib/index.ts that dynamically tracks the focused page/tab
New page event listener in lib/StagehandContext.ts automatically initializes new tabs as StagehandPages
Removed automatic tab closure from lib/handlers/actHandlerUtils.ts and lib/handlers/agentHandler.ts
Added comprehensive tab handling tests with evals/tasks/tab_handling.ts, multi_tab.ts, and agent/kayak.ts
Memory management consideration: tabs must now be manually closed as they're no longer automatically cleaned up

_{11 files reviewed, 7 comments}
_{Edit PR Review Bot Settings | Greptile}

evals/tasks/tab_handling.ts

evals/evals.config.json

evals/tasks/agent/kayak.ts

evals/deterministic/tests/BrowserContext/multiPage.test.ts

evals/tasks/multi_tab.ts

greptile-apps · 2025-06-30T22:41:17Z

lib/index.ts

+    const handler: ProxyHandler<T> = {
+      get: (_t, prop, receiver) => {
+        const real = this.stagehandPage.page as unknown as T;
+        const value = Reflect.get(real, prop, receiver);
+        return typeof value === "function" ? value.bind(real) : value;
+      },
+      set: (_t, prop, value) => {
+        const real = this.stagehandPage.page as unknown as T;
+        Reflect.set(real, prop, value);
+        return true;
+      },
+      has: (_t, prop) => prop in (this.stagehandPage.page as unknown as T),
+      getPrototypeOf: () => proto,
+    };
+
+    return new Proxy(target, handler);


logic: The proxy handler doesn't implement deleteProperty, defineProperty, or ownKeys. This could cause issues with property deletion and object property enumeration.

evals/tasks/agent/kayak.ts

lib/handlers/agentHandler.ts

miguelg719 · 2025-06-30T23:27:14Z

lib/index.ts

+    if (!this._livePageProxy) {
+      this._livePageProxy = this.createLivePageProxy<Page>();
+    }
+    return this._livePageProxy;


stagehand-parity-bot · 2025-07-01T20:23:18Z

🔄 Feature Parity Issue Created

An issue has been automatically created in the Python SDK repository to track parity implementation:
browserbase/stagehand-python#131

@seanmcguire12

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @browserbasehq/[email protected] ### Patch Changes - [#856](#856) [`8a43c5a`](8a43c5a) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - set download behaviour by default - [#857](#857) [`890ffcc`](890ffcc) Thanks [@miguelg719](https://github.com/miguelg719)! - return "not-supported" for elements inside the shadow-dom - [#844](#844) [`64c1072`](64c1072) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - don't automatically close tabs - [#860](#860) [`b077d3f`](b077d3f) Thanks [@miguelg719](https://github.com/miguelg719)! - Set default schema on extract options with no schema - [#842](#842) [`8bcb5d7`](8bcb5d7) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - improved handling for OS level dropdowns - [#846](#846) [`7bf10c5`](7bf10c5) Thanks [@miguelg719](https://github.com/miguelg719)! - Filter attaching to target worker / shared_worker ## @browserbasehq/[email protected] ### Patch Changes - Updated dependencies \[[`8a43c5a`](8a43c5a), [`890ffcc`](890ffcc), [`64c1072`](64c1072), [`b077d3f`](b077d3f), [`8bcb5d7`](8bcb5d7), [`7bf10c5`](7bf10c5)]: - @browserbasehq/[email protected] ## @browserbasehq/[email protected] ### Patch Changes - Updated dependencies \[[`8a43c5a`](8a43c5a), [`890ffcc`](890ffcc), [`64c1072`](64c1072), [`b077d3f`](b077d3f), [`8bcb5d7`](8bcb5d7), [`7bf10c5`](7bf10c5)]: - @browserbasehq/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

- Add live page proxy that dynamically tracks the focused page - Implement context event listener to initialize new pages automatically - Remove automatic tab closing behavior in act_handler_utils and cua_handler - Keep both original and new tabs open when new pages are created - Ensure stagehand.page always references the current active page This implementation matches the behavior of browserbase/stagehand#844

* feat: port new page handling from JS Stagehand PR #844 - Add live page proxy that dynamically tracks the focused page - Implement context event listener to initialize new pages automatically - Remove automatic tab closing behavior in act_handler_utils and cua_handler - Keep both original and new tabs open when new pages are created - Ensure stagehand.page always references the current active page This implementation matches the behavior of browserbase/stagehand#844 * Update stagehand/handlers/cua_handler.py * Update stagehand/handlers/act_handler_utils.py --------- Co-authored-by: Arun Patro <[email protected]> Co-authored-by: Miguel <[email protected]>

* feat: don't close new opened tabs (#161) * feat: port new page handling from JS Stagehand PR #844 - Add live page proxy that dynamically tracks the focused page - Implement context event listener to initialize new pages automatically - Remove automatic tab closing behavior in act_handler_utils and cua_handler - Keep both original and new tabs open when new pages are created - Ensure stagehand.page always references the current active page This implementation matches the behavior of browserbase/stagehand#844 * Update stagehand/handlers/cua_handler.py * Update stagehand/handlers/act_handler_utils.py --------- Co-authored-by: Arun Patro <[email protected]> Co-authored-by: Miguel <[email protected]> * formatting, logs * changeset * fix: update mock_stagehand_client fixture to set internal page properties The page property is now read-only (returns LivePageProxy), so tests need to set the internal _original_page and _active_page properties instead * feat: add page stability check to LivePageProxy for async operations Ensures async operations wait for any pending page switches to complete * formatting * fix: prevent deadlock in page navigation and add page stability tests - Initialize _page_switch_lock in Stagehand constructor - Skip page stability check for navigation methods (goto, reload, go_back, go_forward) - Use lock when switching active pages in context - Add comprehensive tests for LivePageProxy functionality * consolidate original and active page to just one page * Update stagehand/context.py * Update .changeset/gorilla-of-strongest-novelty.md * timeouts * python 3.10 or less compatibility --------- Co-authored-by: Arun Patro <[email protected]> Co-authored-by: Arun Patro <[email protected]> Co-authored-by: Filip Michalsky <[email protected]>

dont close new opened tabs

af8659f

add eval

7909261

seanmcguire12 commented Jun 27, 2025

View reviewed changes

lib/StagehandContext.ts Outdated Show resolved Hide resolved

miguelg719 and others added 10 commits June 26, 2025 22:33

kayak eval for cua

7911ff3

proxy the focused stagehand page

071ebe8

use reference to live proxy of stagehand page

96f1173

preserve Playwright Page prototype on live-proxy

696c447

adapt multi-page unit test to proxy-based stagehand.page

27d0117

moved kayak eval into agent folder

5e9ae73

add another eval

979be53

dont use getStagehandPage for its side effect

2b39d55

await the stagehand.close() in eval

0ef298d

changeset

80ce7f5

seanmcguire12 marked this pull request as ready for review June 30, 2025 22:40

seanmcguire12 added act These changes pertain to the act function combination These changes affect multiple Stagehand functions labels Jun 30, 2025

greptile-apps bot reviewed Jun 30, 2025

View reviewed changes

miguelg719 reviewed Jun 30, 2025

View reviewed changes

evals/tasks/agent/kayak.ts Outdated Show resolved Hide resolved

Update evals/tasks/agent/kayak.ts

7da47b4

miguelg719 reviewed Jun 30, 2025

View reviewed changes

lib/handlers/agentHandler.ts Show resolved Hide resolved

miguelg719 reviewed Jun 30, 2025

View reviewed changes

lib/handlers/agentHandler.ts Show resolved Hide resolved

miguelg719 reviewed Jun 30, 2025

View reviewed changes

miguelg719 approved these changes Jun 30, 2025

View reviewed changes

miguelg719 added the parity To note required feature parity in client SDKs label Jun 30, 2025

the-roaring added parity To note required feature parity in client SDKs and removed parity To note required feature parity in client SDKs labels Jun 30, 2025

fix evals

4eb67cd

the-roaring added parity To note required feature parity in client SDKs and removed parity To note required feature parity in client SDKs labels Jul 1, 2025

Merge branch 'main' into dont-close-new-tabs

5ae360d

seanmcguire12 merged commit 64c1072 into main Jul 1, 2025
15 checks passed

miguelg719 added parity To note required feature parity in client SDKs and removed parity To note required feature parity in client SDKs labels Jul 1, 2025

stagehand-parity-bot bot mentioned this pull request Jul 1, 2025

[Feature Parity] dont close new opened tabs browserbase/stagehand-python#131

Closed

arunpatro mentioned this pull request Jul 22, 2025

feat: don't close new opened tabs browserbase/stagehand-python#161

Merged

miguelg719 mentioned this pull request Jul 26, 2025

feat: don't close new opened tabs (#161) browserbase/stagehand-python#169

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

dont close new opened tabs #844

dont close new opened tabs #844

Uh oh!

seanmcguire12 commented Jun 27, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Jun 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot Jun 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miguelg719 Jun 30, 2025

Uh oh!

Uh oh!

stagehand-parity-bot bot commented Jul 1, 2025

Uh oh!

Uh oh!

dont close new opened tabs #844

dont close new opened tabs #844

Uh oh!

Conversation

seanmcguire12 commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

why

what changed

test plan

Uh oh!

changeset-bot bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miguelg719 Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stagehand-parity-bot bot commented Jul 1, 2025

Uh oh!

Uh oh!

seanmcguire12 commented Jun 27, 2025 •

edited

Loading

changeset-bot bot commented Jun 27, 2025 •

edited

Loading