prevent crashing on shadow DOM elements #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implemented graceful error handling for shadow DOM elements to prevent crashes when accessing unsupported elements in the shadow DOM.
- Added check in
lib/handlers/observeHandler.tsto detect shadow DOM elements by ID format and return 'not-supported' instead of crashing - Created new test file
evals/tasks/shadow_dom.tsto verify graceful handling of shadow DOM interactions - Added 'shadow_dom' task to
evals/evals.config.jsonunder 'act' category for testing - Returns descriptive message "an element inside a shadow DOM" when encountering shadow elements
3 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+194
to
+195
| message: `Element is inside a shadow DOM: ${elementId}`, | ||
| level: 0, |
There was a problem hiding this comment.
logic: Log level 0 suggests critical error, but this is more of a warning/info. Consider using level 1 to match other similar logs
There was a problem hiding this comment.
@seanmcguire12 we need warning level logs haha
seanmcguire12
approved these changes
Jun 30, 2025
This was referenced Jun 30, 2025
Merged
seanmcguire12
pushed a commit
that referenced
this pull request
Jul 4, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @browserbasehq/[email protected] ### Patch Changes - [#856](#856) [`8a43c5a`](8a43c5a) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - set download behaviour by default - [#857](#857) [`890ffcc`](890ffcc) Thanks [@miguelg719](https://github.com/miguelg719)! - return "not-supported" for elements inside the shadow-dom - [#844](#844) [`64c1072`](64c1072) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - don't automatically close tabs - [#860](#860) [`b077d3f`](b077d3f) Thanks [@miguelg719](https://github.com/miguelg719)! - Set default schema on extract options with no schema - [#842](#842) [`8bcb5d7`](8bcb5d7) Thanks [@seanmcguire12](https://github.com/seanmcguire12)! - improved handling for OS level dropdowns - [#846](#846) [`7bf10c5`](7bf10c5) Thanks [@miguelg719](https://github.com/miguelg719)! - Filter attaching to target worker / shared_worker ## @browserbasehq/[email protected] ### Patch Changes - Updated dependencies \[[`8a43c5a`](8a43c5a), [`890ffcc`](890ffcc), [`64c1072`](64c1072), [`b077d3f`](b077d3f), [`8bcb5d7`](8bcb5d7), [`7bf10c5`](7bf10c5)]: - @browserbasehq/[email protected] ## @browserbasehq/[email protected] ### Patch Changes - Updated dependencies \[[`8a43c5a`](8a43c5a), [`890ffcc`](890ffcc), [`64c1072`](64c1072), [`b077d3f`](b077d3f), [`8bcb5d7`](8bcb5d7), [`7bf10c5`](7bf10c5)]: - @browserbasehq/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
TypeError: Cannot read properties of undefined (reading 'replace')what changed
ObserveHandlerto check if the returned ID contains-, which indicates that it will be present in ouridToXpathmapping-, then we log an error, and return"not-supported"as the selector, and"an element inside a shadow DOM"as the descriptiontest plan
"not-supported"as the selector, and"an element inside a shadow DOM"for elements that exist inside the shadow dom