Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Migration for new fields: Use AFTER to keep order as in schema #102

Closed
cebe opened this issue Jul 4, 2022 · 3 comments
Closed

Migration for new fields: Use AFTER to keep order as in schema #102

cebe opened this issue Jul 4, 2022 · 3 comments
Assignees
@SOHELAHMED7
Labels
enhancement New feature or request
Milestone
2.0

Comments

@cebe
Copy link
Owner

cebe commented Jul 4, 2022

Migrations for adding new columns should use "AFTER" keyword to make sure order of columns is the same as in schema.
@cebe cebe added the enhancement New feature or request label Jul 4, 2022
@SOHELAHMED7
Copy link
Contributor

SOHELAHMED7 commented Sep 3, 2022 •
edited
Loading

I tested with MySQL.

I added new property in schema, then executed ./yii gii/api. Migration for new column does not have after() but when I apply newly created migration it automatically adds after the last column/property.

In which cases you are facing this issue?

Edit

Anyway I figured the case where after is nice to have: if we want to add field in between existing fields and not at last position

@SOHELAHMED7 SOHELAHMED7 mentioned this issue Sep 6, 2022
Closed
@SOHELAHMED7 SOHELAHMED7 mentioned this issue Sep 30, 2022
Closed
@SOHELAHMED7 SOHELAHMED7 mentioned this issue Jan 4, 2023
Merged
SOHELAHMED7 added a commit to SOHELAHMED7/yii2-openapi that referenced this issue Jan 16, 2023
@SOHELAHMED7
Merge pull request #11 from SOHELAHMED7/add-after-feature
7219589 
Add after feature cebe#102
@SOHELAHMED7 SOHELAHMED7 mentioned this issue Jan 16, 2023
Merged
@cebe cebe moved this to 🆕 New in yii2-openapi Project Jan 27, 2023
@cebe cebe moved this from 🆕 New to 🏗 In progress in yii2-openapi Project Jan 27, 2023
@cebe cebe added this to the 2.0 milestone Jan 27, 2023
@cebe
Copy link
Owner Author

cebe commented Jan 27, 2023

@SOHELAHMED7 as far as I see this feature is complete. Please close the issue if that is the case.

@SOHELAHMED7
Copy link
Contributor

Yes. this is completed. I cannot see close button. Seems like you have to close this issue

@cebe cebe closed this as completed Jan 27, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in yii2-openapi Project Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SOHELAHMED7 SOHELAHMED7

Labels
enhancement New feature or request
Projects
yii2-openapi Project
Status: ✅ Done
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Add 'AFTER column' feature in migrations; resolve #102 SOHELAHMED7/yii2-openapi
2 participants
@cebe @SOHELAHMED7