This repository was archived by the owner on Jun 4, 2024. It is now read-only.
Add 'AFTER column' feature in migrations; resolve #102 #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is ready for review |
cebe
reviewed
Dec 7, 2022
There was a problem hiding this comment.
What happens if I add a column as the first column? I do not see implementation of FIRST.
https://mariadb.com/kb/en/alter-table/
Syntax is [FIRST | AFTER col_name ] for placement of columns.
Yes it is missing, I am making this PR as draft |
…hub.com:SOHELAHMED7/yii2-openapi into timestamp-enum-x-db-type-bug-fix
…t-work-in-mariadb 100 timestamp migrations do not work in mariadb
…into timestamp-enum-x-db-type-bug-fix
…b2-in-pgsql-in-library-source-code Fix issue 126 - Don't use second db 'pg_test_db_2' in PgSQL in library source code
…-error-and-wrong-data-type-in-mysql' of https://github.com/SOHELAHMED7/yii2-openapi into 107-migrations-are-generated-with-syntax-error-and-wrong-data-type-in-mysql
…e-case-of-the-column-name Draft - Fix issue - Quote issue to preserve the case of the column name cebe#127
…-error-and-wrong-data-type-in-mysql' of https://github.com/SOHELAHMED7/yii2-openapi into 107-migrations-are-generated-with-syntax-error-and-wrong-data-type-in-mysql
…ith-syntax-error-and-wrong-data-type-in-mysql Fix 107-Migrations are generated with syntax error and wrong data type in MySQL
…on-in-pgsql-and-quote-it Draft - Fix cebe#128 - Change Enum name generation in PgSQL and quote it
…MED7/yii2-openapi into add-after-feature
|
I am closing this PR in favour of SOHELAHMED7#11 This PR contains lot of changes from master branch of my fork which is not yet merged. As a result I am facing difficulties in reviewing PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #102
Known limitations (tracked in #110 ):
Lets say we have
If we add col_B2 after col_B then it will added successfully after col_B and before col_C
If we add col_B3, col_B4, col_B5 (more than 1 column in single edit) after col_B then only col_B3 will be added after col_B. col_B4, col_B5 will be added at the end. This is due to: we need to check if previous column exist in DB due to issue #100. Once that issue is fixed, we can make changes to overcome this limitation.