feat: auto-create workflow during attestation #1416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing until we merge and rebase #1414 |
javirln
approved these changes
Oct 21, 2024
jiparis
reviewed
Oct 21, 2024
| @@ -70,7 +70,7 @@ func NewAttestationInit(cfg *AttestationInitOpts) (*AttestationInit, error) { | |||
| } | |||
|
|
|||
| // returns the attestation ID | |||
| func (action *AttestationInit) Run(ctx context.Context, contractRevision int, projectName, workflowName string) (string, error) { | |||
| func (action *AttestationInit) Run(ctx context.Context, contractRevision int, projectName, workflowName, newWorkflowContractName string) (string, error) { | |||
There was a problem hiding this comment.
This changes the current behaviour a little bit. Currently, contract is not mandatory.
There was a problem hiding this comment.
It is not mandatory here either. The name can be empty string
Signed-off-by: Miguel Martinez <[email protected]>
migmartri
force-pushed
the
1415-create-workflow-automatically
branch
from
246d884 to
cd976a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds support to automatically, during
att init, to create the workflow referenced by its name, project and optional contract name.I added this feature as an additional API endpoint in the
attestation serviceinstead of re-using theworkflowservice because I want to make sure this feature can be authenticated, authorized, and potentially toggled in the future, using the attestation token, not a user token.In fact, I'd say that moving forward, I'd remove the ability of the API token to create workflows by default through regular
wf createCloses #1415