Skip to content

chore(tanstack-react-start): Remove Vinxi dependency #6115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Jun 17, 2025

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Jun 13, 2025

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Enabled scroll restoration in routing for improved navigation experience.
    • Introduced a simplified route tree with only essential routes (root, index, sign-in).
    • Updated authentication UI with a new sign-in page and enhanced layout wrappers.
    • Added Vite configuration with Tailwind CSS and TypeScript path alias support.
    • Improved server integration with streamlined routing and Clerk authentication handlers.
  • Bug Fixes
    • Removed deprecated dependencies and legacy tooling to enhance stability.
  • Chores
    • Updated dependencies to caret ranges for easier maintenance.
    • Cleaned up ignore files and removed obsolete formatting configurations.
    • Simplified environment variable access by removing event context dependency.
    • Consolidated routing interfaces and typings for better developer experience.

Copy link

vercel bot commented Jun 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ⬜️ Skipped (Inspect) Jun 17, 2025 5:08am

Copy link
Contributor

coderabbitai bot commented Jun 13, 2025

📝 Walkthrough

Walkthrough

This change updates both the TanStack React Router and TanStack React Start integration templates and associated packages. It upgrades dependencies to newer versions, removes the Vinxi build system in favor of Vite, and simplifies package dependencies. Several files in the tanstack-react-start template are deleted, including configuration, route definitions, styling files, and client/server entry points, while new equivalents are introduced under a src directory. Route tree generation and router setup are restructured, and server-side integration is updated to use Vite and Clerk authentication. TypeScript and Tailwind configurations are adjusted, and environment variable handling is simplified by removing context-based retrieval.

Suggested reviewers

  • dstaley

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa516b2 and 90cd963.

📒 Files selected for processing (1)
  • packages/upgrade/src/codemods/__tests__/__fixtures__/transform-clerk-provider-dynamic.fixtures.js (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/upgrade/src/codemods/tests/fixtures/transform-clerk-provider-dynamic.fixtures.js
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Analyze (javascript-typescript)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

changeset-bot bot commented Jun 13, 2025

🦋 Changeset detected

Latest commit: 90cd963

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/tanstack-react-start Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wobsoriano
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @wobsoriano - the snapshot version command generated the following package versions:

Package Version
@clerk/agent-toolkit 0.1.1-snapshot.v20250613154540
@clerk/astro 2.9.1-snapshot.v20250613154540
@clerk/backend 2.1.0-snapshot.v20250613154540
@clerk/chrome-extension 2.4.12-snapshot.v20250613154540
@clerk/clerk-js 5.68.1-snapshot.v20250613154540
@clerk/elements 0.23.33-snapshot.v20250613154540
@clerk/clerk-expo 2.13.1-snapshot.v20250613154540
@clerk/expo-passkeys 0.3.10-snapshot.v20250613154540
@clerk/express 1.7.0-snapshot.v20250613154540
@clerk/fastify 2.4.0-snapshot.v20250613154540
@clerk/localizations 3.16.5-snapshot.v20250613154540
@clerk/nextjs 6.21.1-snapshot.v20250613154540
@clerk/nuxt 1.7.1-snapshot.v20250613154540
@clerk/clerk-react 5.31.10-snapshot.v20250613154540
@clerk/react-router 1.6.0-snapshot.v20250613154540
@clerk/remix 4.8.1-snapshot.v20250613154540
@clerk/shared 3.9.7-snapshot.v20250613154540
@clerk/tanstack-react-start 0.17.0-snapshot.v20250613154540
@clerk/testing 1.8.1-snapshot.v20250613154540
@clerk/themes 2.2.50-snapshot.v20250613154540
@clerk/types 4.60.1-snapshot.v20250613154540
@clerk/vue 1.8.8-snapshot.v20250613154540

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit

npm i @clerk/[email protected] --save-exact

@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/expo-passkeys

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/nuxt

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/react-router

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-react-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

@clerk/vue

npm i @clerk/[email protected] --save-exact

@wobsoriano
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @wobsoriano - the snapshot version command generated the following package versions:

Package Version
@clerk/agent-toolkit 0.1.2-snapshot.v20250616221205
@clerk/astro 2.9.2-snapshot.v20250616221205
@clerk/backend 2.2.0-snapshot.v20250616221205
@clerk/chrome-extension 2.4.13-snapshot.v20250616221205
@clerk/clerk-js 5.69.1-snapshot.v20250616221205
@clerk/clerk-expo 2.13.2-snapshot.v20250616221205
@clerk/express 1.7.1-snapshot.v20250616221205
@clerk/fastify 2.4.1-snapshot.v20250616221205
@clerk/localizations 3.16.6-snapshot.v20250616221205
@clerk/nextjs 6.23.0-snapshot.v20250616221205
@clerk/nuxt 1.7.2-snapshot.v20250616221205
@clerk/react-router 1.6.1-snapshot.v20250616221205
@clerk/remix 4.8.2-snapshot.v20250616221205
@clerk/tanstack-react-start 0.18.0-snapshot.v20250616221205
@clerk/testing 1.8.2-snapshot.v20250616221205

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit

npm i @clerk/[email protected] --save-exact

@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/nuxt

npm i @clerk/[email protected] --save-exact

@clerk/react-router

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-react-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@wobsoriano wobsoriano merged commit d9b9b5e into main Jun 17, 2025
37 checks passed
@wobsoriano wobsoriano deleted the rob/tanstack-devinxi branch June 17, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants