Skip to content

chore(tanstack-react-start): Remove Vinxi dependency #6115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Jun 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
0c1ed86
chore: Update handler types
wobsoriano May 21, 2025
76d48ef
chore: use exported types
wobsoriano Jun 11, 2025
52f99bd
chore: merge headers
wobsoriano Jun 11, 2025
c2a9a98
chore: fix merged objects
wobsoriano Jun 11, 2025
5f35627
chore: fix merged objects
wobsoriano Jun 11, 2025
4e5d73b
chore: update tests
wobsoriano Jun 11, 2025
351aed4
chore: update .gitignore
wobsoriano Jun 11, 2025
62c872b
Merge branch 'main' into rob/eco-645-tanstack-devinxi
wobsoriano Jun 11, 2025
ce2739c
chore: add changeset
wobsoriano Jun 11, 2025
1c9cf4a
fix conflicts
wobsoriano Jun 12, 2025
573bcc5
chore: remove als dependency for now
wobsoriano Jun 12, 2025
8cae6e5
link actual github issue
wobsoriano Jun 13, 2025
d743eba
chore: add tanstack router template
wobsoriano Jun 13, 2025
215b02f
chore: add back ts router turbo entry
wobsoriano Jun 13, 2025
d7bf9c9
chore: add tsrouter test
wobsoriano Jun 13, 2025
c57e1d6
chore: update to latest ts versions
wobsoriano Jun 13, 2025
94347d2
chore: update changeset
wobsoriano Jun 13, 2025
e576652
chore: update changeset
wobsoriano Jun 13, 2025
d7f4148
Merge branch 'main' into rob/tanstack-devinxi
wobsoriano Jun 13, 2025
23ff4ae
chore: remove ALS usage
wobsoriano Jun 16, 2025
246e925
Merge branch 'main' into rob/tanstack-devinxi
wobsoriano Jun 16, 2025
7680a64
chore: apply suggested edits
wobsoriano Jun 16, 2025
e2154bd
chore: apply nitpicks
wobsoriano Jun 16, 2025
8c3fe6e
chore: clean up
wobsoriano Jun 16, 2025
92a53d1
chore: add vite to dev deps template
wobsoriano Jun 16, 2025
ac1ef7a
chore: dedupe
wobsoriano Jun 16, 2025
9fbde23
Merge branch 'main' into rob/tanstack-devinxi
wobsoriano Jun 16, 2025
74ebc25
Merge branch 'main' into rob/tanstack-devinxi
wobsoriano Jun 16, 2025
b10169b
chore: checkout main lockfile and reinstall
wobsoriano Jun 16, 2025
0ae237a
chore: dedupe
wobsoriano Jun 16, 2025
df51682
Merge branch 'main' into rob/tanstack-devinxi
wobsoriano Jun 16, 2025
9586319
Update package.json
wobsoriano Jun 16, 2025
257b032
Update package.json
wobsoriano Jun 16, 2025
f03e6d0
Update package.json
wobsoriano Jun 16, 2025
2109bac
Update package.json
wobsoriano Jun 16, 2025
bf4ba1d
Update package.json
wobsoriano Jun 16, 2025
dd18aa0
Update package.json
wobsoriano Jun 16, 2025
fa516b2
Merge branch 'main' into rob/tanstack-devinxi
wobsoriano Jun 17, 2025
ca6ff66
Merge branch 'main' into rob/tanstack-devinxi
wobsoriano Jun 17, 2025
90cd963
test
wobsoriano Jun 17, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/curly-dots-stand.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@clerk/tanstack-react-start': minor
---

Updated minimum required version of `@tanstack/react-start` to 1.121.0, which removes the need for Vinxi.

See [full migration guide](https://github.com/TanStack/router/discussions/2863#discussioncomment-13104960).
7 changes: 3 additions & 4 deletions integration/templates/tanstack-react-router/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@
"start": "vite"
},
"dependencies": {
"@tanstack/react-router": "1.120.17",
"@tanstack/react-router-devtools": "1.120.17",
"@tanstack/router-generator": "1.120.17",
"@tanstack/router-plugin": "1.120.17",
"@tanstack/react-router": "1.121.21",
"@tanstack/react-router-devtools": "1.121.21",
"@tanstack/router-plugin": "1.121.21",
"react": "18.3.1",
"react-dom": "18.3.1"
},
Expand Down
1 change: 1 addition & 0 deletions integration/templates/tanstack-react-router/src/main.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const router = createRouter({
routeTree,
defaultPreload: 'intent',
defaultStaleTime: 5000,
scrollRestoration: true,
});

// Register things for typesafety
Expand Down
30 changes: 0 additions & 30 deletions integration/templates/tanstack-react-router/src/posts.tsx

This file was deleted.

225 changes: 52 additions & 173 deletions integration/templates/tanstack-react-router/src/routeTree.gen.ts
Original file line number Diff line number Diff line change
@@ -1,196 +1,75 @@
/* prettier-ignore-start */

/* eslint-disable */

// @ts-nocheck

// noinspection JSUnusedGlobalSymbols

// This file is auto-generated by TanStack Router

// Import Routes

import { Route as rootRoute } from './routes/__root';
import { Route as PostsImport } from './routes/posts';
import { Route as LayoutImport } from './routes/_layout';
import { Route as IndexImport } from './routes/index';
import { Route as PostsIndexImport } from './routes/posts.index';
import { Route as PostsPostIdImport } from './routes/posts.$postId';
import { Route as LayoutLayout2Import } from './routes/_layout/_layout-2';
import { Route as LayoutLayout2LayoutBImport } from './routes/_layout/_layout-2/layout-b';
import { Route as LayoutLayout2LayoutAImport } from './routes/_layout/_layout-2/layout-a';
// This file was automatically generated by TanStack Router.
// You should NOT make any changes in this file as it will be overwritten.
// Additionally, you should also exclude this file from your linter and/or formatter to prevent it from being checked or modified.

// Create/Update Routes

const PostsRoute = PostsImport.update({
path: '/posts',
getParentRoute: () => rootRoute,
} as any);
import { Route as rootRouteImport } from './routes/__root';
import { Route as SignInRouteImport } from './routes/sign-in';
import { Route as IndexRouteImport } from './routes/index';

const LayoutRoute = LayoutImport.update({
id: '/_layout',
getParentRoute: () => rootRoute,
const SignInRoute = SignInRouteImport.update({
id: '/sign-in',
path: '/sign-in',
getParentRoute: () => rootRouteImport,
} as any);

const IndexRoute = IndexImport.update({
path: '/',
getParentRoute: () => rootRoute,
} as any);

const PostsIndexRoute = PostsIndexImport.update({
const IndexRoute = IndexRouteImport.update({
id: '/',
path: '/',
getParentRoute: () => PostsRoute,
getParentRoute: () => rootRouteImport,
} as any);

const PostsPostIdRoute = PostsPostIdImport.update({
path: '/$postId',
getParentRoute: () => PostsRoute,
} as any);

const LayoutLayout2Route = LayoutLayout2Import.update({
id: '/_layout-2',
getParentRoute: () => LayoutRoute,
} as any);

const LayoutLayout2LayoutBRoute = LayoutLayout2LayoutBImport.update({
path: '/layout-b',
getParentRoute: () => LayoutLayout2Route,
} as any);

const LayoutLayout2LayoutARoute = LayoutLayout2LayoutAImport.update({
path: '/layout-a',
getParentRoute: () => LayoutLayout2Route,
} as any);

// Populate the FileRoutesByPath interface
export interface FileRoutesByFullPath {
'/': typeof IndexRoute;
'/sign-in': typeof SignInRoute;
}
export interface FileRoutesByTo {
'/': typeof IndexRoute;
'/sign-in': typeof SignInRoute;
}
export interface FileRoutesById {
__root__: typeof rootRouteImport;
'/': typeof IndexRoute;
'/sign-in': typeof SignInRoute;
}
export interface FileRouteTypes {
fileRoutesByFullPath: FileRoutesByFullPath;
fullPaths: '/' | '/sign-in';
fileRoutesByTo: FileRoutesByTo;
to: '/' | '/sign-in';
id: '__root__' | '/' | '/sign-in';
fileRoutesById: FileRoutesById;
}
export interface RootRouteChildren {
IndexRoute: typeof IndexRoute;
SignInRoute: typeof SignInRoute;
}

declare module '@tanstack/react-router' {
interface FileRoutesByPath {
'/sign-in': {
id: '/sign-in';
path: '/sign-in';
fullPath: '/sign-in';
preLoaderRoute: typeof SignInRouteImport;
parentRoute: typeof rootRouteImport;
};
'/': {
id: '/';
path: '/';
fullPath: '/';
preLoaderRoute: typeof IndexImport;
parentRoute: typeof rootRoute;
};
'/_layout': {
id: '/_layout';
path: '';
fullPath: '';
preLoaderRoute: typeof LayoutImport;
parentRoute: typeof rootRoute;
};
'/posts': {
id: '/posts';
path: '/posts';
fullPath: '/posts';
preLoaderRoute: typeof PostsImport;
parentRoute: typeof rootRoute;
};
'/_layout/_layout-2': {
id: '/_layout/_layout-2';
path: '';
fullPath: '';
preLoaderRoute: typeof LayoutLayout2Import;
parentRoute: typeof LayoutImport;
};
'/posts/$postId': {
id: '/posts/$postId';
path: '/$postId';
fullPath: '/posts/$postId';
preLoaderRoute: typeof PostsPostIdImport;
parentRoute: typeof PostsImport;
};
'/posts/': {
id: '/posts/';
path: '/';
fullPath: '/posts/';
preLoaderRoute: typeof PostsIndexImport;
parentRoute: typeof PostsImport;
};
'/_layout/_layout-2/layout-a': {
id: '/_layout/_layout-2/layout-a';
path: '/layout-a';
fullPath: '/layout-a';
preLoaderRoute: typeof LayoutLayout2LayoutAImport;
parentRoute: typeof LayoutLayout2Import;
};
'/_layout/_layout-2/layout-b': {
id: '/_layout/_layout-2/layout-b';
path: '/layout-b';
fullPath: '/layout-b';
preLoaderRoute: typeof LayoutLayout2LayoutBImport;
parentRoute: typeof LayoutLayout2Import;
preLoaderRoute: typeof IndexRouteImport;
parentRoute: typeof rootRouteImport;
};
}
}

// Create and export the route tree

export const routeTree = rootRoute.addChildren({
IndexRoute,
LayoutRoute: LayoutRoute.addChildren({
LayoutLayout2Route: LayoutLayout2Route.addChildren({
LayoutLayout2LayoutARoute,
LayoutLayout2LayoutBRoute,
}),
}),
PostsRoute: PostsRoute.addChildren({ PostsPostIdRoute, PostsIndexRoute }),
});

/* prettier-ignore-end */

/* ROUTE_MANIFEST_START
{
"routes": {
"__root__": {
"filePath": "__root.tsx",
"children": [
"/",
"/_layout",
"/posts"
]
},
"/": {
"filePath": "index.tsx"
},
"/_layout": {
"filePath": "_layout.tsx",
"children": [
"/_layout/_layout-2"
]
},
"/posts": {
"filePath": "posts.tsx",
"children": [
"/posts/$postId",
"/posts/"
]
},
"/_layout/_layout-2": {
"filePath": "_layout/_layout-2.tsx",
"parent": "/_layout",
"children": [
"/_layout/_layout-2/layout-a",
"/_layout/_layout-2/layout-b"
]
},
"/posts/$postId": {
"filePath": "posts.$postId.tsx",
"parent": "/posts"
},
"/posts/": {
"filePath": "posts.index.tsx",
"parent": "/posts"
},
"/_layout/_layout-2/layout-a": {
"filePath": "_layout/_layout-2/layout-a.tsx",
"parent": "/_layout/_layout-2"
},
"/_layout/_layout-2/layout-b": {
"filePath": "_layout/_layout-2/layout-b.tsx",
"parent": "/_layout/_layout-2"
}
}
}
ROUTE_MANIFEST_END */
const rootRouteChildren: RootRouteChildren = {
IndexRoute: IndexRoute,
SignInRoute: SignInRoute,
};
export const routeTree = rootRouteImport._addFileChildren(rootRouteChildren)._addFileTypes<FileRouteTypes>();
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@ export const Route = createRootRoute({
function RootComponent() {
return (
<ClerkProvider>
<Outlet />
<div className='p-2'>
<div className='border-b'>I'm a layout</div>
<div>
<Outlet />
</div>
</div>
<TanStackRouterDevtools position='bottom-right' />
</ClerkProvider>
);
Expand Down

This file was deleted.

4 changes: 3 additions & 1 deletion integration/templates/tanstack-react-router/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
"compilerOptions": {
"strict": true,
"esModuleInterop": true,
"jsx": "react-jsx"
"jsx": "react-jsx",
"lib": ["DOM", "DOM.Iterable", "ES2022"],
"skipLibCheck": true
}
}
10 changes: 8 additions & 2 deletions integration/templates/tanstack-react-router/vite.config.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
import { defineConfig } from 'vite';
import react from '@vitejs/plugin-react';
import { TanStackRouterVite } from '@tanstack/router-plugin/vite';
import { tanstackRouter } from '@tanstack/router-plugin/vite';

// https://vitejs.dev/config/
export default defineConfig({
plugins: [TanStackRouterVite(), react()],
plugins: [
tanstackRouter({
target: 'react',
autoCodeSplitting: true,
}),
react(),
],
});
10 changes: 5 additions & 5 deletions integration/templates/tanstack-react-start/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ yarn.lock
.env
.vercel
.output
.vinxi

.nitro
/build/
/api/
/server/build
/public/build
.vinxi
# Sentry Config File
/public/build # Sentry Config File
.env.sentry-build-plugin
/test-results/
/playwright-report/
/blob-report/
/playwright/.cache/
.tanstack
5 changes: 0 additions & 5 deletions integration/templates/tanstack-react-start/.prettierignore

This file was deleted.

Loading
Loading