Add Wei as Reviewer for Logging/Metrics #1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chombium
approved these changes
Aug 30, 2025
There was a problem hiding this comment.
@weili-broadcom is new to the team, but she works hard and is already doing some great things in the Logging and Metrics area. Keep up the good work @weili-broadcom 💪 🙌
ameowlia
approved these changes
Sep 12, 2025
|
Ideally this PR would be created by @weili-broadcom so the CLA bot can check for it being signed |
rkoster
approved these changes
Sep 13, 2025
beyhan
approved these changes
Sep 15, 2025
|
If my counting is right we have enough approvals here to merge. Congrats @weili-broadcom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wei is working to ramp-up in the logging/metrics area to replace some lapsed contributors (see #1294).
Per https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md#promotion-to-reviewer-or-approver, two existing approvers for each working group area need to attest that Wei meets the criteria for the Reviewer role.
cc @weili-broadcom @cloudfoundry/wg-app-runtime-platform-logging-and-metrics-approvers @cloudfoundry/wg-app-runtime-platform-metric-store-approvers @cloudfoundry/wg-foundational-infrastructure-system-logging-and-metrics-rsyslog-event-log-approvers