Leonlu2/time values and issues #1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dcast.py 2. add time_values=* handler in parse_date as validation 3. add test_time_values_wildcard in test_covidcast.py
2. add unittest for placeholder on issues
krivard
previously approved these changes
Jan 19, 2023
Co-authored-by: Katie Mazaitis <[email protected]>
Co-authored-by: Katie Mazaitis <[email protected]>
melange396
reviewed
Jan 19, 2023
Comment on lines
383
to
+387
| try: | ||
| return int(s.replace("-", "")) | ||
| if s == "*": | ||
| return s | ||
| else: | ||
| return int(s.replace("-", "")) |
There was a problem hiding this comment.
Suggested change
| try: | |
| return int(s.replace("-", "")) | |
| if s == "*": | |
| return s | |
| else: | |
| return int(s.replace("-", "")) | |
| if s == "*": | |
| return s | |
| try: | |
| return int(s.replace("-", "")) |
the if "*" doesnt need to be in the try block (which is there to make sure s is made up of numbers (and dashes)), and the else is superfluous since the return happens right above it.
Comment on lines
+477
to
+481
| if issues == ["*"]: | ||
| self.retable(history_table) | ||
| else: | ||
| self.retable(history_table) | ||
| self.where_integers("issue", issues) |
There was a problem hiding this comment.
Suggested change
| if issues == ["*"]: | |
| self.retable(history_table) | |
| else: | |
| self.retable(history_table) | |
| self.where_integers("issue", issues) | |
| self.retable(history_table) | |
| if issues != ["*"]: | |
| self.where_integers("issue", issues) |
you dont have to repeat the retable() line, and the where_integers() call is better done under the if instead of the else (by reversing the comparison).
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #672
Prerequisites:
devbranchdevSummary