-
Notifications
You must be signed in to change notification settings - Fork 67
Leonlu2/time values and issues #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9e3ad67
1. add contidional time_values=* handler in parse_timer_mairs in covi…
LeonLu2 d08c011
Merge branch 'dev' into leonlu2/time_values_and_issues
LeonLu2 9b50619
Merge branch 'dev' into leonlu2/time_values_and_issues
LeonLu2 2d1ad93
Merge branch 'dev' into leonlu2/time_values_and_issues
LeonLu2 9b1eaeb
1. add issues=* handler to apply_issues_filter
LeonLu2 2a13311
1. Merge branch 'dev' into current branch
LeonLu2 3f2bacb
1. Merge branch 'dev' into leonlu2/time_values_and_issues
LeonLu2 269b294
1. Merge dev to current branch
LeonLu2 79e32dc
Update src/server/_params.py
LeonLu2 c53c15a
Update integrations/server/test_covidcast.py
LeonLu2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -474,8 +474,11 @@ def apply_lag_filter(self, history_table: str, lag: Optional[int]) -> "QueryBuil | |||||||||||||||||
|
||||||||||||||||||
def apply_issues_filter(self, history_table: str, issues: Optional[TimeValues]) -> "QueryBuilder": | ||||||||||||||||||
if issues: | ||||||||||||||||||
self.retable(history_table) | ||||||||||||||||||
self.where_integers("issue", issues) | ||||||||||||||||||
if issues == ["*"]: | ||||||||||||||||||
self.retable(history_table) | ||||||||||||||||||
else: | ||||||||||||||||||
self.retable(history_table) | ||||||||||||||||||
self.where_integers("issue", issues) | ||||||||||||||||||
Comment on lines
+477
to
+481
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
you dont have to repeat the |
||||||||||||||||||
return self | ||||||||||||||||||
|
||||||||||||||||||
def apply_as_of_filter(self, history_table: str, as_of: Optional[int]) -> "QueryBuilder": | ||||||||||||||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
if "*"
doesnt need to be in thetry
block (which is there to make sures
is made up of numbers (and dashes)), and theelse
is superfluous since thereturn
happens right above it.