Skip to content

build: upgrade both master and release-22.1 branches to use go 1.17.11 #82808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
knz opened this issue Jun 13, 2022 · 3 comments
Closed

build: upgrade both master and release-22.1 branches to use go 1.17.11 #82808

knz opened this issue Jun 13, 2022 · 3 comments
Assignees
@rail
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Comments

@knz
Copy link
Contributor

knz commented Jun 13, 2022 •
edited by cockroach-jira-scripts
Loading

Describe the problem

We are seeing excess allocations due to the upgrade to go 1.17 and this bug:
golang/go#52790

This was fixed in go 1.17.11.

Currently master uses 1.17.10 and release-22.1 uses 1.17.6.

Expected behavior

Upgrade both branches to build with 1.17.11.

Jira issue: CRDB-16676
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-build-system labels Jun 13, 2022
@knz
Copy link
Contributor Author

knz commented Jun 13, 2022

cc @rail for triage

@rail
Copy link
Member

rail commented Jun 13, 2022

I'll take care of this this week.

@rail rail self-assigned this Jun 13, 2022
@rail rail mentioned this issue Jun 13, 2022
Merged
10 tasks
rail added a commit to rail/cockroach that referenced this issue Jun 13, 2022
@rail
Upgrade Go to version 1.17.11
e494bfe 
* [x] Adjust version in Docker image
* [x] Adjust version in the TeamCity agent image
* [x] Rebuild and push the Docker image
* [x] Download ALL the archives (`.tar.gz`, `.zip`) for the new Go
  version from https://golang.org/dl/ and mirror them in the
  `public-bazel-artifacts` bucket in the `Bazel artifacts` project in
  GCP (sub-directory `go`, next to the other Go SDK's).
* [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may
  need to bump
  [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit
  the filenames listed in `sdks` and update all the hashes to match what
  you mirrored in the step above.
* [x] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then
  `bazel fetch @distdir//:archives` to ensure you've updated all hashes
  to the correct value.
* [x] Bump the version in `builder.sh` accordingly
* [x] Bump the default installed version of Go in `bootstrap-debian.sh`
* [ ] Update the `builder.dockerImage` parameter in the TeamCity
  [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams)
  and
  [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams)
  projects.
* [ ] Deploy new TeamCity agent images

Partially addresses cockroachdb#82808

Release note: None
rail added a commit to rail/cockroach that referenced this issue Jun 13, 2022
@rail
Upgrade Go to version 1.17.11
b3df084 
* [x] Adjust version in Docker image
* [x] Adjust version in the TeamCity agent image
* [x] Rebuild and push the Docker image
* [x] Download ALL the archives (`.tar.gz`, `.zip`) for the new Go
  version from https://golang.org/dl/ and mirror them in the
  `public-bazel-artifacts` bucket in the `Bazel artifacts` project in
  GCP (sub-directory `go`, next to the other Go SDK's).
* [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may
  need to bump
  [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit
  the filenames listed in `sdks` and update all the hashes to match what
  you mirrored in the step above.
* [x] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then
  `bazel fetch @distdir//:archives` to ensure you've updated all hashes
  to the correct value.
* [x] Bump the version in `builder.sh` accordingly
* [x] Bump the default installed version of Go in `bootstrap-debian.sh`
* [ ] Update the `builder.dockerImage` parameter in the TeamCity
  [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams)
  and
  [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams)
  projects.
* [ ] Deploy new TeamCity agent images

Partially addresses cockroachdb#82808

Release note: None
@rail rail mentioned this issue Jun 13, 2022
Merged
10 tasks
rail added a commit to rail/cockroach that referenced this issue Jun 13, 2022
@rail
Upgrade Go to version 1.17.11
699723d 
* [x] Adjust version in Docker image
* [x] Adjust version in the TeamCity agent image
* [x] Rebuild and push the Docker image
* [x] Download ALL the archives (`.tar.gz`, `.zip`) for the new Go
  version from https://golang.org/dl/ and mirror them in the
  `public-bazel-artifacts` bucket in the `Bazel artifacts` project in
  GCP (sub-directory `go`, next to the other Go SDK's).
* [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may
  need to bump
  [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit
  the filenames listed in `sdks` and update all the hashes to match what
  you mirrored in the step above.
* [x] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then
  `bazel fetch @distdir//:archives` to ensure you've updated all hashes
  to the correct value.
* [x] Bump the version in `builder.sh` accordingly
* [x] Bump the default installed version of Go in `bootstrap-debian.sh`
* [ ] Update the `builder.dockerImage` parameter in the TeamCity
  [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams)
  and
  [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams)
  projects.
* [ ] Deploy new TeamCity agent images

Partially addresses cockroachdb#82808

Release note: None
rail added a commit to rail/cockroach that referenced this issue Jun 13, 2022
@rail
Upgrade Go to version 1.17.11
a9acfc2 
* [x] Adjust version in Docker image
* [x] Adjust version in the TeamCity agent image
* [x] Rebuild and push the Docker image
* [x] Download ALL the archives (`.tar.gz`, `.zip`) for the new Go
  version from https://golang.org/dl/ and mirror them in the
  `public-bazel-artifacts` bucket in the `Bazel artifacts` project in
  GCP (sub-directory `go`, next to the other Go SDK's).
* [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may
  need to bump
  [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit
  the filenames listed in `sdks` and update all the hashes to match what
  you mirrored in the step above.
* [x] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then
  `bazel fetch @distdir//:archives` to ensure you've updated all hashes
  to the correct value.
* [x] Bump the version in `builder.sh` accordingly
* [x] Bump the default installed version of Go in `bootstrap-debian.sh`
* [ ] Update the `builder.dockerImage` parameter in the TeamCity
  [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams)
  and
  [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams)
  projects.
* [ ] Deploy new TeamCity agent images

Partially addresses cockroachdb#82808

Release note: None
craig bot pushed a commit that referenced this issue Jun 13, 2022
@e-mbrown @nvanbenschoten @rail
Merge #82677 #82797 #82816
0e5927a 
82677: sql, pgwire: Add `SEVERITY_NONLOCALIZED` error field r=e-mbrown a=e-mbrown

Resolves #81794

Release note (sql change): We now send the Severity_Nonlocalized field
in the pgwire Notice Response.

82797: kv: extract etcd/raft utilities into raftutil library r=nvanbenschoten a=nvanbenschoten

Commit pulled from #82758.

This commit extracts some scattered logic to interpret the state of an `etcd/raft` Status into a new `raftutil` library. The library initially has two functions: `ReplicaIsBehind` and `ReplicaMayNeedSnapshot`. In the future, I expect that we'll extract more helper functions that make working with `etcd/raft` easier into this library.

82816: Upgrade Go to version 1.17.11 r=jlinder,rickystewart a=rail

* [x] Adjust version in Docker image
* [x] Adjust version in the TeamCity agent image
* [x] Rebuild and push the Docker image
* [x] Download ALL the archives (`.tar.gz`, `.zip`) for the new Go version from https://golang.org/dl/ and mirror them in the  `public-bazel-artifacts` bucket in the `Bazel artifacts` project in GCP (sub-directory `go`, next to the other Go SDK's).
* [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit the filenames listed in `sdks` and update all the hashes to match what you mirrored in the step above.
* [x] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then `bazel fetch `@distdir//:archives`` to ensure you've updated all hashes to the correct value.
* [x] Bump the version in `builder.sh` accordingly
* [x] Bump the default installed version of Go in `bootstrap-debian.sh`
* [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and  [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects.
* [ ] Deploy new TeamCity agent images

Partially addresses #82808

Release note: None


Co-authored-by: e-mbrown <[email protected]>
Co-authored-by: Nathan VanBenschoten <[email protected]>
Co-authored-by: Rail Aliiev <[email protected]>
@rail
Copy link
Member

rail commented Jun 14, 2022

Done.

@rail rail closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rail rail

Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rail @knz