Skip to content

release-22.1: Upgrade Go to version 1.17.11 #82819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2022
Merged

release-22.1: Upgrade Go to version 1.17.11 #82819

merged 1 commit into from
Jun 14, 2022

Conversation

rail
Copy link
Member

@rail rail commented Jun 13, 2022 •
edited
Loading

Backport 1/1 commits from #82816.

/cc @cockroachdb/release

  • Adjust version in Docker image
  • Adjust version in the TeamCity agent image
  • Rebuild and push the Docker image
  • Download ALL the archives (.tar.gz, .zip) for the new Go version from https://golang.org/dl/ and mirror them in the public-bazel-artifacts bucket in the Bazel artifacts project in GCP (sub-directory go, next to the other Go SDK's).
  • Bump the version in WORKSPACE under go_download_sdk. You may need to bump rules_go. Also edit the filenames listed in sdks and update all the hashes to match what you mirrored in the step above.
  • Run ./dev generate bazel to refresh distdir_files.bzl, then bazel fetch @distdir//:archives to ensure you've updated all hashes to the correct value.
  • Bump the version in builder.sh accordingly
  • Bump the default installed version of Go in bootstrap-debian.sh
  • Update the builder.dockerImage parameter in the TeamCity Cockroach and Internal projects.
  • Deploy new TeamCity agent images

Partially addresses #82808

Release note: None
Release justification: the new Go version addresses some TLS regression fixes.

@rail rail added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system T-dev-inf labels Jun 13, 2022
@rail rail requested a review from a team as a code owner June 13, 2022 13:55
@rail rail self-assigned this Jun 13, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jun 13, 2022 •
edited by rail
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

rickystewart
rickystewart approved these changes Jun 13, 2022
View reviewed changes
@rail
Upgrade Go to version 1.17.11
a9acfc2 
* [x] Adjust version in Docker image
* [x] Adjust version in the TeamCity agent image
* [x] Rebuild and push the Docker image
* [x] Download ALL the archives (`.tar.gz`, `.zip`) for the new Go
  version from https://golang.org/dl/ and mirror them in the
  `public-bazel-artifacts` bucket in the `Bazel artifacts` project in
  GCP (sub-directory `go`, next to the other Go SDK's).
* [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may
  need to bump
  [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit
  the filenames listed in `sdks` and update all the hashes to match what
  you mirrored in the step above.
* [x] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then
  `bazel fetch @distdir//:archives` to ensure you've updated all hashes
  to the correct value.
* [x] Bump the version in `builder.sh` accordingly
* [x] Bump the default installed version of Go in `bootstrap-debian.sh`
* [ ] Update the `builder.dockerImage` parameter in the TeamCity
  [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams)
  and
  [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams)
  projects.
* [ ] Deploy new TeamCity agent images

Partially addresses cockroachdb#82808

Release note: None
@rail rail force-pushed the backport22.1-82816 branch from b3df084 to a9acfc2 Compare June 13, 2022 15:38
@rail rail merged commit 64374c2 into cockroachdb:release-22.1 Jun 14, 2022
@rail rail deleted the backport22.1-82816 branch June 14, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickystewart rickystewart rickystewart approved these changes

Assignees

@rail rail

Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rail @cockroach-teamcity @rickystewart