Clarify go compiler version requirements for all releases. #6132
Conversation
|
This change is |
|
Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/db0cded89c7cbabe4ca22103575dd2228c9f39fc/ Edited pages: |
andreimatei
force-pushed
the
go-versions
branch
from
db0cded to
3c4f658
Compare
There was a problem hiding this comment.
I think in nearly all cases we have compile-time dependencies on our listed minimum go version, so I wouldn't even suggest that you can use IGNORE_GOVERS to try older versions.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei, @bdarnell, and @jseldess)
v2.0/install-cockroachdb.html, line 154 at r1 (raw file):
<td>Version 1.10.*. Older go versions might work by doing <code>make build IGNORE_GOVERS=1</code>, but you're on your own. 1.11 and above is not recommended.
For 2.0, we can make a stronger statement: Binaries built with Go 1.11 or above will not work reliably.
andreimatei
force-pushed
the
go-versions
branch
from
3c4f658 to
d7190e3
Compare
There was a problem hiding this comment.
Kept the note about IGNORE_GOVERS when we start talking about patch versions.
Reviewable status:
v2.0/install-cockroachdb.html, line 154 at r1 (raw file):
Previously, bdarnell (Ben Darnell) wrote…
For 2.0, we can make a stronger statement: Binaries built with Go 1.11 or above will not work reliably.
Done.
There was a problem hiding this comment.
Reviewable status:
v19.1/install-cockroachdb-linux.html, line 133 at r2 (raw file):
<tr> <td>Go</td> <td>Version 1.11.6+. Older go versions might work by doing
Editorial nits:
Version 1.11.6+ is required, but 1.12 and above is not recommended. Older versions might work via <code>make build IGNORE_GOVERS=1</code>.
v19.1/install-cockroachdb-mac.html, line 122 at r2 (raw file):
<tr> <td>Go</td> <td>Version 1.11.6+. Older go versions might work by doing
Nits:
Version 1.11.6+ is required, but 1.12 and above is not recommended. Older versions might work via <code>make build IGNORE_GOVERS=1</code>.
v19.2/install-cockroachdb-linux.html, line 133 at r2 (raw file):
<tr> <td>Go</td> <td>Version 1.12.12+. Older go versions might work by doing
Version 1.12.12+ is required, but 1.13 and above is not recommended. Older versions might work via <code>make build IGNORE_GOVERS=1</code>.
v19.2/install-cockroachdb-mac.html, line 159 at r2 (raw file):
<tr> <td>Go</td> <td>Version 1.12.12+. Older go versions might work by doing
Nits:
Version 1.12.12+ is required, but 1.13 and above is not recommended. Older versions might work via <code>make build IGNORE_GOVERS=1</code>.
v2.0/install-cockroachdb.html, line 154 at r1 (raw file):
Previously, andreimatei (Andrei Matei) wrote…
Done.
Nits:
Version 1.10.* is required, but 1.11 and above is known to not work reliably.
v2.0/install-cockroachdb.html, line 340 at r2 (raw file):
<tr> <td>Go</td> <td>Version 1.10.*. 1.11+ is known to not work reliably.</td>
Nits:
Version 1.10.* is required, but 1.11 and above is known to not work reliably.
v2.1/install-cockroachdb-linux.html, line 133 at r2 (raw file):
<tr> <td>Go</td> <td>Version 1.10.*. 1.11+ is not recommended.</td>
Nits:
Version 1.10.* is required, but 1.11 and above is known to not work reliably.
v2.1/install-cockroachdb-mac.html, line 161 at r2 (raw file):
<tr> <td>Go</td> <td>Version 1.10.*. 1.11+ is not recommended.</td>
Nits:
Version 1.10.* is required, but 1.11 and above is known to not work reliably.
v20.1/install-cockroachdb-linux.html, line 133 at r2 (raw file):
<tr> <td>Go</td> <td>Version 1.12.12+ or 1.13.4+. Older go versions might work by doing
Nits:
Version 1.12.12+ or 1.13.4+ is required, but 1.14 and above is not recommended. Older versions might work via <code>make build IGNORE_GOVERS=1</code>.
v20.1/install-cockroachdb-mac.html, line 159 at r2 (raw file):
<tr> <td>Go</td> <td>Version 1.12.12+ or 1.13.4+. Older go versions might work by doing
Nits:
Version 1.12.12+ or 1.13.4+ is required, but 1.14 and above is not recommended. Older versions might work via <code>make build IGNORE_GOVERS=1</code>.
|
Will merge and address nits in follow-up. |
Fixes #6097