Skip to content

Conversation

ccurvey
Copy link
Contributor

@ccurvey ccurvey commented Apr 29, 2023

by making RetryError inherit from dramatiq.errors.Retry, we can avoid having Dramatiq log a stack trace every time a task returns False. (see Bogdanp/dramatiq#469)

I also changed a few of the log message so that we know which task returned False or completed successfully.

Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ccurvey,

Thanks for the contribution. Always appreciated.

I left you a couple of small suggestions. Moreover, please take a look at the CI results.

Cheers!
Joe

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7b0b990) 97.86% compared to head (285a969) 97.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files          17       17           
  Lines         701      701           
=======================================
  Hits          686      686           
  Misses         15       15           
Impacted Files Coverage Δ
joeflow/runner/dramatiq.py 97.43% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codingjoe codingjoe merged commit 6fed3fd into codingjoe:main May 22, 2023
@codingjoe codingjoe changed the title improve logging readability for Dramatiq Include task representation Dramatiq log messages May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants