-
-
Notifications
You must be signed in to change notification settings - Fork 26
Include task representation Dramatiq log messages #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include task representation Dramatiq log messages #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ccurvey,
Thanks for the contribution. Always appreciated.
I left you a couple of small suggestions. Moreover, please take a look at the CI results.
Cheers!
Joe
Co-authored-by: Johannes Maron <[email protected]>
Co-authored-by: Johannes Maron <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 17 17
Lines 701 701
=======================================
Hits 686 686
Misses 15 15
☔ View full report in Codecov by Sentry. |
by making
RetryError
inherit fromdramatiq.errors.Retry
, we can avoid having Dramatiq log a stack trace every time a task returns False. (see Bogdanp/dramatiq#469)I also changed a few of the log message so that we know which task returned False or completed successfully.