Skip to content

Include task representation Dramatiq log messages #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 22, 2023
Merged

Include task representation Dramatiq log messages #78

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
609bb93
change base class of RetryError to limit Dramatiq loggign
ccurvey Apr 29, 2023
120e9c3
make logging more explicit
ccurvey Apr 29, 2023
ef0d4b7
Update joeflow/runner/dramatiq.py
ccurvey Apr 30, 2023
1b98523
Update joeflow/runner/dramatiq.py
ccurvey Apr 30, 2023
385ddf4
revert exception message change
ccurvey Apr 30, 2023
9ffd609
reformatted w/ Black
ccurvey Apr 30, 2023
285a969
Fix file format
codingjoe May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions joeflow/runner/dramatiq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def task_runner(*, task_pk, workflow_pk, countdown=None, eta=None, retries=0):
)


class RetryError(Exception):
class RetryError(dramatiq.errors.Retry):
"""Raised to retry a task if the task result is ``False``."""

pass
Expand Down Expand Up @@ -56,10 +56,14 @@ def _dramatiq_task_runner(task_pk, workflow_pk, retries=0):
logger.exception("Execution of %r failed", task)
else:
if result is False:
logger.info("Task returned False, retrying …")
_dramatiq_task_runner.logger.info("%r returned False, retrying …", task)
raise RetryError("Task returned False, retrying …")
elif result is True:
result = None
logger.info("Task completed successful, starting next tasks: %s", result)
_dramatiq_task_runner.logger.info(
"%r completed successfully, starting next tasks: %s",
task,
result,
)
task.start_next_tasks(next_nodes=result)
task.finish()