Skip to content

mystery checkbox in side-bar #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manabuishii opened this issue Sep 2, 2022 · 10 comments · Fixed by #347
Closed

mystery checkbox in side-bar #244

manabuishii opened this issue Sep 2, 2022 · 10 comments · Fixed by #347

Comments

@manabuishii
Copy link
Contributor

Hello .
I'm Manabu Ishii.

Thanks nice user guide !!

Question .
There is a checkbox at left pain "Topics" . ( Red circle)
How can I use it ?
In my Mac Chrome browser , nothing happens at least my environment.

Suggestion .
I think center pain move to left . ( Blue arrow )
At least my browser there is some spaces , so first time I can not find left pain menu.

スクリーンショット 2022-09-02 10 37 14

@kinow
Copy link
Member

kinow commented Sep 2, 2022

Hi @manabuishii ! 👋

Good catch, I noticed something similar: 0604c7a#commitcomment-82739272

@Fienne
Copy link
Contributor

Fienne commented Oct 12, 2022

I think what we should do is remove the sidebar from the right side of the introduction and topics pages OR add the sidebar to the Tutorials, FAQ and Licenses pages, so that the design on all pages look consistent.
How does this sound @kinow ?

@kinow
Copy link
Member

kinow commented Oct 12, 2022

My preference is to have the same layout in every page. The landing page of the user guide, IMO, is no different than the rest of the guide. So having a consistent layout prevents users from having to treat pages in any different way (i.e. on this page you have a sidebar, on this one you don't... on this page your search is here, on that page it is not...).

@Fienne
Copy link
Contributor

Fienne commented Oct 12, 2022

So what we should do is add the sidebar to the pages that don't have it?

@kinow
Copy link
Member

kinow commented Oct 12, 2022

So what we should do is add the sidebar to the pages that don't have it?

Not sure, that was just my opinion 🙂 One issue here is that check box that appears on the desktop view (I think it's not shown on mobile?). I would start investigating if this change can be reverted or if there is a setting or dependency somewhere that needs changing: 0604c7a#commitcomment-82739272

@Fienne
Copy link
Contributor

Fienne commented Oct 12, 2022

No, it's not shown on mobile. I don't really know the function of the checkbox. What does it do?

@kinow
Copy link
Member

kinow commented Oct 12, 2022

No, it's not shown on mobile. I don't really know the function of the checkbox. What does it do?

I think it doesn't do anything. I suspect it is rendered by accident as the function used in the commit was either not supposed to be used at that part of the template, or because the template requires some setting for that function to work correctly. But that requires some investigation to confirm it 👍

But no functional feature. We could even try to simply hide it in CSS if needed, but I think it would be better to understand why it was added and what's the correct fix.

@Fienne
Copy link
Contributor

Fienne commented Oct 12, 2022

I'll try finding out the file which renders it and understand why it was added. If you're able to figure it out before I do, please share.

@kinow
Copy link
Member

kinow commented Oct 12, 2022

Excellent @Fienne . I probanly won't work on it (busy with $work and a few other tasks). Good luck!

@Mackenzie-OO7
Copy link
Contributor

I'll try finding out the file which renders it and understand why it was added. If you're able to figure it out before I do, please share.

Hey, did you figure this out yet?

@mr-c mr-c changed the title Question and Suggestion about new user guide 2 . Topic mystery checkbox in side-bar Oct 24, 2022
@mr-c mr-c closed this as completed in #347 Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants