Skip to content

clean up syntax #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2018
Merged

clean up syntax #105

merged 2 commits into from
Apr 18, 2018

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Apr 6, 2018

No description provided.

@mr-c mr-c requested review from tom-tan and tobyhodges and removed request for tom-tan April 6, 2018 15:12
@@ -8,8 +8,7 @@ hints:
baseCommand: javac

requirements:
- class: InlineJavascriptRequirement
- class: InitialWorkDirRequirement
InitialWorkDirRequirement:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This syntax is not valid in v1.0.2 because the spec says that requirements should be an array.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spec itself a mapping using the value of the class field as the key is allowed: https://github.com/common-workflow-language/common-workflow-language/blob/master/v1.0/Process.yml#L811 but I see that it isn't rendering in the HTML version: http://www.commonwl.org/v1.0/CommandLineTool.html#CommandLineTool I also reviewed all 10 captures of this page in archive.org across 2016 & 2017 and the same rendering bug is present.

@tetron Any ideas?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opend an issue about this at common-workflow-language/schema_salad#167 and I think it is rather important to fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mr-c I got it. Thanks for the information!

@mr-c mr-c merged commit 6a029b4 into gh-pages Apr 18, 2018
@mr-c mr-c deleted the mr-c-patch-1 branch April 18, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants