Skip to content

clean up syntax #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2018
Merged

clean up syntax #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4292f39
clean up syntax
mr-c Apr 6, 2018
e3dcd6d
update for fixed newline preservation in cwltool
mr-c Apr 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions _includes/cwl/15-staging/linkfile.cwl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ hints:
baseCommand: javac

requirements:
- class: InlineJavascriptRequirement
- class: InitialWorkDirRequirement
InitialWorkDirRequirement:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This syntax is not valid in v1.0.2 because the spec says that requirements should be an array.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spec itself a mapping using the value of the class field as the key is allowed: https://github.com/common-workflow-language/common-workflow-language/blob/master/v1.0/Process.yml#L811 but I see that it isn't rendering in the HTML version: http://www.commonwl.org/v1.0/CommandLineTool.html#CommandLineTool I also reviewed all 10 captures of this page in archive.org across 2016 & 2017 and the same rendering bug is present.

@tetron Any ideas?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opend an issue about this at common-workflow-language/schema_salad#167 and I think it is rather important to fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mr-c I got it. Thanks for the information!

listing:
- $(inputs.src)

Expand Down
4 changes: 2 additions & 2 deletions _includes/cwl/conformance-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,10 @@
output:
example_out:
class: File
checksum: sha1$5d3f955d1bb862ec618bc2f7ca4c5fa29fa39e89
checksum: sha1$5509385b089c054ac9f9890dccef666eda7eb79d
basename: output.txt
location: Any
size: 22
size: 23

# Section 15
- doc: Test for section 15
Expand Down