Skip to content

Fix a typo in the TOperator test #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

Gnimuc
Copy link
Contributor

@Gnimuc Gnimuc commented May 11, 2025

We may need to find a way to catch this.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Vipul-Cariappa
Copy link
Collaborator

I cannot see a codecov bot comment. Is it not running?

Copy link
Collaborator

@Vipul-Cariappa Vipul-Cariappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change being done here is the self argument. Using both object and toperator is acceptable. And in both cases we are reusing the variable declared before.
I would say object is better as it conveys the correct usage.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Gnimuc
Copy link
Contributor Author

Gnimuc commented May 13, 2025

I would say object is better as it conveys the correct usage.

Could you elaborate on the correctness of using object? object is a dangling pointer that points to a destructed object in another test case above.

@mcbarton
Copy link
Collaborator

I cannot see a codecov bot comment. Is it not running?

@Vipul-Cariappa This is due to the accidentally removal of the coverage job from the ci. This PR fixes it #577 . Once this PR is in, rebase this PR and you should see a coverage comment. Feel free to review and approval the PR, if it hasn't already been done, when you see this message.

Copy link
Collaborator

@Vipul-Cariappa Vipul-Cariappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. I assumed you were invoking a constructor, so I thought it did not matter what the object pointed to. But I see that it is a method that is being invoked. This is correct, and the previous usage was wrong.
LGTM!

@vgvassilev vgvassilev merged commit 28ba16e into compiler-research:main May 13, 2025
70 checks passed
@Gnimuc Gnimuc deleted the test-patch branch May 14, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants