Skip to content

Add coverage job back to ci #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented May 13, 2025

Description

Please include a summary of changes, motivation and context for this PR.

The coverage job appears has dissapeared from our ci. No idea when this happened. This PR should fix it.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.37%. Comparing base (6975c54) to head (37f0cd9).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   76.27%   76.37%   +0.10%     
==========================================
  Files           9        9              
  Lines        3650     3645       -5     
==========================================
  Hits         2784     2784              
+ Misses        866      861       -5     

see 1 file with indirect coverage changes

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Vipul-Cariappa
Copy link
Collaborator

Shouldn't this exist in Ubuntu-X86 instead of Ubuntu-ARM? As Ubuntu-X86 is the most used platform.

@mcbarton
Copy link
Collaborator Author

mcbarton commented May 13, 2025

Shouldn't this exist in Ubuntu-X86 instead of Ubuntu-ARM? As Ubuntu-X86 is the most used platform.

It doesn't matter if the job runs on X86 or ARM. You can create a coverage report on both to upload. We need Ubuntu 22.04 though, as I tried Ubuntu 24.04 , and our ci needs modifying for it to work on that platform, and its best to have a coverage job back in the repo sooner rather than later.

@Vipul-Cariappa Vipul-Cariappa requested a review from vgvassilev May 13, 2025 12:27
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vgvassilev vgvassilev merged commit 13d0e69 into compiler-research:main May 13, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants