move rootless-cni-infra image to quay.io
#7625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
AkihiroSuda
reviewed
Sep 14, 2020
AkihiroSuda
reviewed
Sep 14, 2020
AkihiroSuda
reviewed
Sep 14, 2020
AkihiroSuda
reviewed
Sep 14, 2020
vrothberg
force-pushed
the
fix-7617
branch
2 times, most recently
from
db20c6f to
a87916c
Compare
AkihiroSuda
reviewed
Sep 14, 2020
|
LGTM |
AkihiroSuda
reviewed
Sep 14, 2020
|
Thanks! Nit: can we s/CNI_ROOTLESS/ROOTLESS_CNI/g for consistency with the image name? |
Sure! Currently rebuilding and updating the digests 👍 |
AkihiroSuda
approved these changes
Sep 14, 2020
|
Tests aren't hip. |
AkihiroSuda
reviewed
Sep 15, 2020
AkihiroSuda
reviewed
Sep 15, 2020
AkihiroSuda
reviewed
Sep 15, 2020
Move the `rootless-cni-infra` image to `quay.io/libpod/rootless-cni-image:$tag` where $tag has the format `$version-$architecture`. Whenever we upload a new image (e.g., after changing the Containerfile), we need to make sure to increase the version number (an ordinary integer for simplicity) so we have a notion of support. Thanks to @AkihiroSuda for working on rootless CNI! Fixes: containers#7617 Signed-off-by: Valentin Rothberg <[email protected]>
Use the newly built image from quay.io. Also reference the image by digest. Signed-off-by: Valentin Rothberg <[email protected]>
Signed-off-by: Valentin Rothberg <[email protected]>
AkihiroSuda
approved these changes
Sep 15, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commits.
Fixes: #7617