Skip to content
This repository was archived by the owner on Feb 10, 2021. It is now read-only.

Update version to match Podman #34

Closed
wants to merge 1 commit into from
Closed

Update version to match Podman #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
PYTHON ?= $(shell command -v python3 2>/dev/null || command -v python)
DESTDIR ?= /
PODMAN_VERSION ?= '0.11.1.1'
PODMAN_VERSION ?= $(podman version -f "{{ .Version }}")

.PHONY: python-podman
python-podman:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

setup(
name='podman',
version=os.environ.get('PODMAN_VERSION', '0.0.0'),
version=os.environ.get('PODMAN_VERSION', '1.4.3'),
Copy link
Collaborator

@4383 4383 Jun 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not an issue to merge these changes but they will be removed if we merge my changes.

Also I've some comments:

  1. My proposed changes on Improve packaging by using PBR #25 would avoid to do this and would manage this by using git tag. With my changes you just need to publish a new git tag on github who refer your version of podman and it will be automatically published on pypi without any manual handling, and you don't need to take care about the version management, just publish a git tag...

  2. I don't know in which cases the PODMAN_VERSION env var can exist on the system, I suppose when podman is installed, so in this case if we install a different version of python-podman not the really the same than podman you need to assume that they can be incompatible or things like that... I'm sure it's a good things to retrieve the python client version from the podman version...
    Also how to manage the client version if we want to install from pypi? If you choose to use the env var to determine the python package version, and if you build it locally and the then publish it on pypi you need to take care to have the right podman installed version.

I hope my comment can help you.

Do not hesitate to ask things if needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am willing to entertain other ideas. The version of Podman that we build with python-podman should be pretty close. I would expect that podman-python 1.4.3 should work with podman 1.4.3 or later versions. Might work with older versions.

description='A library for communicating with a Podman server',
author='Jhon Honce',
author_email='[email protected]',
Expand Down