Skip to content

Bump deployment api version #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 29, 2019

Signed-off-by: yeya24 [email protected]

What this PR does:
extensions/v1beta1 is deprecated. Usdate to apps/v1
Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've also run kubeval on all files and the validation pass.

Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24
Copy link
Contributor Author

yeya24 commented Jan 21, 2020

Hi, do I need to change something else to get this merged?

@pracucci
Copy link
Contributor

Thanks @yeya24 for the heads up. 2+ maintainers already approved it, so let me merge it.

@pracucci pracucci merged commit c56d00a into cortexproject:master Jan 21, 2020
@yeya24 yeya24 deleted the bump-apiversion branch January 21, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants