Run kubeval to validate K8S spec files #1944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pushed |
pracucci
force-pushed
the
validate-k8s-specs
branch
from
76bd5da to
d91ef7b
Compare
|
@bboreham Thanks for your help. The CI lint has passed (see results) with the updated What should be the process now? |
pracucci
force-pushed
the
validate-k8s-specs
branch
from
93989d4 to
d86738d
Compare
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
validate-k8s-specs
branch
from
d86738d to
e3e6481
Compare
bboreham
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
While reviewing the PR #1941, I've realized we don't run any validation on K8S spec files in CI. I think it could be useful as signal to spot trivial issues during the review process.
In this PR, I'm proposing to run
kubevalin CI. This would require to publish a newbuild-image(for which I don't have privileges), but first I would like to scout if this is a desired change.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]