Skip to content

Upgraded Thanos to 0.11.0 and switched to binary index header #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pracucci
Copy link
Contributor

@pracucci pracucci commented Mar 6, 2020

What this PR does:
In this PR:

  • Upgraded Thanos to 0.11.0
  • Switched to binary index header with an option to go back if necessary (considered experimental on Thanos side, but the whole blocks storage is experimental in Cortex so I would suggest to use the binary header as default)

Upgraded dependencies:

Preliminary results in a small test cluster:

Screen Shot 2020-03-06 at 15 54 26

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci
Copy link
Contributor Author

pracucci commented Mar 6, 2020

Integration tests in CI are failing because they run on a older version of Go. I will upgrade the Go version used by CI (integration tests) in a separate PR (which will need to get merged before this).

@pracucci pracucci force-pushed the upgrade-thanos-and-allow-to-enable-binary-index-header branch from c465a1a to a8fce0e Compare March 6, 2020 15:59
@pracucci pracucci force-pushed the upgrade-thanos-and-allow-to-enable-binary-index-header branch from a8fce0e to f727d03 Compare March 6, 2020 16:40
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Alertmanager changes seems fine until it's fixed upstream

@pracucci pracucci merged commit efddde4 into cortexproject:master Mar 9, 2020
@pracucci pracucci deleted the upgrade-thanos-and-allow-to-enable-binary-index-header branch March 9, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants