Build image now supports linux/arm64 as well #4165
Conversation
Added new Makefile target to build multi-arch build image. Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
| tar xzvf hugo.tar.gz -C /usr/bin && \ | ||
| chmod +x /usr/bin/hugo | ||
|
|
||
| ENV SHFMT_VERSION=3.2.4 |
There was a problem hiding this comment.
Bumped version, as 3.1.0 had no arm64 binary.
|
|
||
| # Install faillint used to lint go imports in CI. | ||
| ENV FAILLINT_VERSION=1.5.0 | ||
| RUN GO111MODULE=on go get github.com/fatih/faillint@v${FAILLINT_VERSION} && \ |
There was a problem hiding this comment.
Moved faillint to shared go get build.
|
|
||
| # Install embedmd used to embed content into markdown files. | ||
| ENV EMBEDMD_VERSION=1.0.0 | ||
| RUN GO111MODULE=on go get github.com/campoy/embedmd@v${EMBEDMD_VERSION} && \ |
There was a problem hiding this comment.
Moved embedmd to shared go get build.
Signed-off-by: Peter Štibraný <[email protected]>
| %/$(UPTODATE): %/Dockerfile | ||
| @echo | ||
| $(SUDO) docker build --build-arg=revision=$(GIT_REVISION) --build-arg=goproxyValue=$(GOPROXY_VALUE) -t $(IMAGE_PREFIX)$(shell basename $(@D)) $(@D)/ | ||
| $(SUDO) docker tag $(IMAGE_PREFIX)$(shell basename $(@D)) $(IMAGE_PREFIX)$(shell basename $(@D)):$(IMAGE_TAG) |
There was a problem hiding this comment.
Why was this removed? I think we need it to keep CI working, am I wrong?
There was a problem hiding this comment.
It's back now... in single docker build command, with multiple -t flags.
There was a problem hiding this comment.
Reverted it back, due to upcoming change in #4211, which builds images for both platforms, but only tags native one with $(IMAGE_PREFIX)$(shell basename $(@D)).
There was a problem hiding this comment.
I had to revert that change in #4211, as Github Actions don't support --platform argument when running docker :(
| mv shfmt /usr/bin | ||
|
|
||
| RUN curl -sfL https://github.com/raw/golangci/golangci-lint/master/install.sh| sh -s -- -b /usr/bin v1.27.0 | ||
| RUN GO111MODULE=on go get -tags netgo \ |
There was a problem hiding this comment.
What's the impact of removing -tags netgo?
There was a problem hiding this comment.
According to https://golang.org/doc/go1.5, netgo is no longer necessary.
There was a problem hiding this comment.
In practice, I haven't noticed any difference.
There was a problem hiding this comment.
Another nice test to do could be pushing the image and updating it in CI workflows, so we can test CI running on the new build-image.
I've updated this PR to use newly built image from this PR.
Signed-off-by: Peter Štibraný <[email protected]>
…ded hugo. Signed-off-by: Peter Štibraný <[email protected]>
We need 'extended' version, and binaries for this version are not available for our archs. Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
| @echo Please use push-multiarch-build-image to build and push build image for all supported architectures. | ||
| touch $@ | ||
|
|
||
| push-multiarch-build-image: |
There was a problem hiding this comment.
Who is expected to run this?
There was a problem hiding this comment.
This target is to be used by maintainer building a new build-image. I've updated how-to-update-the-build-image.md file to make it clear. Note that it should work regardless of platform that dev is using.
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Build-image can be built for linux/amd64 (as before) and also linux/arm64 platform.
Added new Makefile target to build multi-arch build image. Such image can only be pushed to repository, and not used locally by Docker. Docker only fetches platform-specific image, when it doesn't have one locally.
To use the feature, one needs to enable
buildkitfeature in docker config. Building amd64 and arm64 should work regardless of host platform -- docker will simply run non-native platform under qemu.