Build arm64 binaries and packages #4211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
It doesn't work on GHA. Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
pracucci
approved these changes
May 27, 2021
Makefile
Outdated
| sha256sum ./dist/cortex-$$os-$$arch | cut -d ' ' -f 1 > ./dist/cortex-$$os-$$arch-sha-256; \ | ||
| echo "Building query-tee for $$os/$$arch"; \ | ||
| GOOS=$$os GOARCH=$$arch CGO_ENABLED=0 go build $(GO_FLAGS) -o ./dist/query-tee-$$os-$$arch ./cmd/query-tee; \ | ||
| sha256sum ./dist/query-tee-$$os-$$arch | cut -d ' ' -f 1 > ./dist/cortex-$$os-$$arch-sha-256; \ |
There was a problem hiding this comment.
Suggested change
| sha256sum ./dist/query-tee-$$os-$$arch | cut -d ' ' -f 1 > ./dist/cortex-$$os-$$arch-sha-256; \ | |
| sha256sum ./dist/query-tee-$$os-$$arch | cut -d ' ' -f 1 > ./dist/query-tee-$$os-$$arch-sha-256; \ |
There was a problem hiding this comment.
Whoops, good catch! Thanks.
Signed-off-by: Peter Štibraný <[email protected]>
ac1214
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jun 4, 2021
* Build arm64 binaries. Signed-off-by: Peter Štibraný <[email protected]> * Build also deb/rpm packages for arm64, and test them. Signed-off-by: Peter Štibraný <[email protected]> * Don't use --platform when building docker images. It doesn't work on GHA. Signed-off-by: Peter Štibraný <[email protected]> * Fixes Signed-off-by: Peter Štibraný <[email protected]> * Fixes Signed-off-by: Peter Štibraný <[email protected]> * Fixes Signed-off-by: Peter Štibraný <[email protected]> * Remove tabs. Signed-off-by: Peter Štibraný <[email protected]> * Remove unused tags. Signed-off-by: Peter Štibraný <[email protected]> * Added comment. Signed-off-by: Peter Štibraný <[email protected]> * Don't build packages during all build. Signed-off-by: Peter Štibraný <[email protected]> * Remove unused PACKAGES var. Signed-off-by: Peter Štibraný <[email protected]> * Fix digest name. Signed-off-by: Peter Štibraný <[email protected]> Signed-off-by: Albert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR adds support for building arm64 binary when running
make dist(for linux and macos), and also deb/rpm packages for linux/arm64 when runningmake packages; make test-packages.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]