feat: Added support for logging of HTTP Headers #4803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Speaks <[email protected]>
Signed-off-by: Zach Speaks <[email protected]>
alvinlin123
reviewed
Jul 27, 2022
alvinlin123
reviewed
Jul 27, 2022
alvinlin123
reviewed
Jul 27, 2022
alvinlin123
reviewed
Jul 27, 2022
alvinlin123
reviewed
Jul 27, 2022
alvinlin123
reviewed
Jul 27, 2022
|
@zspeaks can you also share an example how the actual log looks like? |
alvinlin123
reviewed
Jul 27, 2022
|
Here's an example of what the logging looks like. Note: for the purposes of this example, I'm sending simulated requests with known headers and contents. In an actual running scenario, these additions to the logs would appear alongside the other information in the logs NOT on their own as they do here. With that said, here's examples for 1, 2 and 3 headers being included in the request. |
Signed-off-by: Zach Speaks <[email protected]>
zspeaks
force-pushed
the
HTTPHeaderLogging
branch
from
0926efb to
a2f4d2c
Compare
…erLogging # Conflicts: # CHANGELOG.md
Signed-off-by: Zach Speaks <[email protected]>
Added Header Propagation to Ingester and Querier Signed-off-by: Zach Speaks <[email protected]> Signed-off-by: Zachary Speaks <[email protected]>
Signed-off-by: Zach Speaks <[email protected]> Signed-off-by: Zachary Speaks <[email protected]>
Signed-off-by: Zach Speaks <[email protected]> Signed-off-by: Zachary Speaks <[email protected]>
Signed-off-by: Zachary Speaks <[email protected]>
Signed-off-by: Zachary Speaks <[email protected]>
Signed-off-by: Zachary Speaks <[email protected]>
Signed-off-by: Zachary Speaks <[email protected]>
danielblando
approved these changes
Aug 25, 2022
zspeaks
commented
Aug 25, 2022
…vice is not being used Signed-off-by: Zachary Speaks <[email protected]>
alanprot
reviewed
Aug 26, 2022
alanprot
reviewed
Aug 26, 2022
Signed-off-by: Zachary Speaks <[email protected]>
Signed-off-by: Zachary Speaks <[email protected]>
Signed-off-by: Zachary Speaks <[email protected]>
alanprot
reviewed
Aug 30, 2022
alanprot
reviewed
Aug 30, 2022
…th existing code Signed-off-by: Zachary Speaks <[email protected]>
alvinlin123
approved these changes
Aug 31, 2022
Signed-off-by: Zachary Speaks <[email protected]>
alanprot
reviewed
Aug 31, 2022
pkg/util/log/log.go
Outdated
Comment on lines
155
to
160
| func InjectHeadersIntoHTTPRequest(headerMap map[string]string, request *http.Request) { | ||
| for header, contents := range headerMap { | ||
| request.Header.Add(HeaderPropagationStringForRequestLogging, header) | ||
| request.Header.Add(HeaderPropagationStringForRequestLogging, contents) | ||
| } | ||
| } |
There was a problem hiding this comment.
Could we pass the headers as is instead of creating a special header (httpheaderforwardingforlogging)?
Signed-off-by: Zachary Speaks <[email protected]>
Signed-off-by: Zachary Speaks <[email protected]>
Signed-off-by: Zachary Speaks <[email protected]>
Signed-off-by: Zachary Speaks <[email protected]>
alanprot
approved these changes
Sep 1, 2022
|
Nice!! |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds support for the addition of the contents of HTTP headers to logs.
Which issue(s) this PR fixes:
Fixes #4799
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]