Add log message for partial failure on push #4853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielblando
force-pushed
the
improve-logging-ingester
branch
from
fcd6501 to
36aea64
Compare
Signed-off-by: Daniel Deluiggi <[email protected]>
danielblando
force-pushed
the
improve-logging-ingester
branch
from
36aea64 to
7097003
Compare
alvinlin123
reviewed
Sep 8, 2022
| @@ -1006,6 +1006,7 @@ func (i *Ingester) Push(ctx context.Context, req *cortexpb.WriteRequest) (*corte | |||
| // of it, so that we can return it back to the distributor, which will return a | |||
| // 400 error to the client. The client (Prometheus) will not retry on 400, and | |||
| // we actually ingested all samples which haven't failed. | |||
| level.Warn(logutil.WithContext(ctx, i.logger)).Log("msg", "partial failure to push", "err", err) | |||
There was a problem hiding this comment.
I am curious on if this log would be too noisy?
There was a problem hiding this comment.
I don't expect it to be. This is just in failures cases to append to tsdb, because of limit or storage issue. The idea behind is to use this with the new header to log feature (#4803). That would allow us to have a tracker between distributor and ingester issue.
Currently ingester does not log any message on this type of failures, and the log in the server middleware does not implement the header logs feature from cortex, which seems correct as it is a generic logging.
alvinlin123
approved these changes
Sep 9, 2022
friedrichg
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add partial failure logs to ingester push. We currently have logs on grpc_logging which just log the first error. This gives us more visibility on what is occurring in the ingester.
New log:
Existent log:
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]