Skip instant query round tripper if sharding is not applicable. #5062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedrichg
requested changes
Dec 30, 2022
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
go-downstream
branch
from
cca990e to
d5cf4d8
Compare
|
@friedrichg Thanks for the review! Updated my pr. PTAL |
friedrichg
approved these changes
Dec 30, 2022
3 tasks
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
…exproject#5062) * Skip instant query round tripper if sharding is not applicable. Signed-off-by: Ben Ye <[email protected]> * address review comments Signed-off-by: Ben Ye <[email protected]> * update changelog Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Alex Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye [email protected]
What this PR does:
From the trace, the instant query tripperware adds some overhead for response serilization/deserilization. For this example, it takes 15s+ while the whole query time is 23s.
The issue is, if the tenant doesn't enable vertical sharding, or the query itself is not even shardable, the additional overhead is still there and we don't have a way to skip that. This pr checks whether vertical sharding is applicable before passing the request down to the tripperware.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]