Fix read reader multiple times in QFE #5202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this! Can you add the changelog? |
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
fix-multiple-times-reader
branch
from
5a53009 to
716fb42
Compare
The bug was introduced by a change that we haven't released #5062 . Is it fine to skip the changelog? |
Signed-off-by: Ben Ye <[email protected]>
alanprot
approved these changes
Mar 8, 2023
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
* fix read reader multiple times in QFE Signed-off-by: Ben Ye <[email protected]> * write to error Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Alex Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
To prevent reading the reader multiple times in #5201, instead we first parse the form to read the body if it is a POST request, then we set body to the buffer we copied. This could make sure we read the buf later only once.
I have added integration test cases for query frontend with vertical sharding enabled. Tests should pass after this fix.
Note:
If it is a GET request and it sets body to non empty, in this case the buffer is nil so we will set body to nil. But I think this is fine as
ParseFormmethod only cares about url params and ignores body if it is a GET request.Which issue(s) this PR fixes:
Fixes #5201
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]