[chore] Update Prometheus/Thanos/Thanos engine #5177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
friedrichg
reviewed
Mar 29, 2023
Comment on lines
+123
to
+127
| seriesDataTouched *prometheus.HistogramVec | ||
| seriesDataFetched *prometheus.HistogramVec | ||
| seriesDataSizeTouched *prometheus.HistogramVec | ||
| seriesDataSizeFetched *prometheus.HistogramVec | ||
| seriesBlocksQueried prometheus.Histogram |
There was a problem hiding this comment.
Cortex uses these metrics. we need to change them too
cortex/pkg/storegateway/bucket_store_metrics.go
Lines 217 to 221 in ed36a62
This was referenced Mar 29, 2023
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
* Updating Dependencies Signed-off-by: Alan Protasio <[email protected]> * fix test Signed-off-by: Alan Protasio <[email protected]> * fix ling Signed-off-by: Alan Protasio <[email protected]> * fix test Signed-off-by: Alan Protasio <[email protected]> * Adding KeepFiringFor on the response Signed-off-by: Alan Protasio <[email protected]> * changelog Signed-off-by: Alan Protasio <[email protected]> --------- Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Alex Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Update Dependencies:
Prometheus: https://github.com/prometheus/prometheus/tree/v2.42.0
Thanos: thanos-io/thanos@fdeea39
Thanos Engine: thanos-io/promql-engine@ae04bbe
Prometheus introduced a breaking change to reuse iterators: prometheus/prometheus#11334
It also includes a new alerting rule field (
keep_firing_for): prometheus/prometheus#11827Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]