Store Gateway: Convert metrics from summary to histograms #5239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortex_bucket_store_series_blocks_queried cortex_bucket_store_series_data_fetched cortex_bucket_store_series_data_size_touched_bytes cortex_bucket_store_series_data_size_fetched_bytes cortex_bucket_store_series_data_touched cortex_bucket_store_series_result_series Signed-off-by: Friedrich Gonzalez <[email protected]>
friedrichg
changed the title
Signed-off-by: Friedrich Gonzalez <[email protected]>
friedrichg
changed the title
|
Thanks! Should we pull this on the 1.15 release? @yeya24 WDYT? |
alanprot
approved these changes
Mar 29, 2023
|
Yeah @alanprot, I agree we need another RC for this. THanks |
yeya24
approved these changes
Mar 29, 2023
yeya24
reviewed
Mar 29, 2023
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| * [CHANGE] Tracing: Use the default OTEL trace sampler when `-tracing.otel.exporter-type` is set to `awsxray`. #5141 | |||
| * [CHANGE] Ingester partial error log line to debug level. #5192 | |||
| * [CHANGE] Change HTTP status code from 503/422 to 499 if a request is canceled. #5220 | |||
| * [CHANGE] Store gateways summary metrics have been converted to histograms `cortex_bucket_store_series_blocks_queried`, `cortex_bucket_store_series_data_fetched`, `cortex_bucket_store_series_data_size_touched_bytes`, `cortex_bucket_store_series_data_size_fetched_bytes`, `cortex_bucket_store_series_data_touched`, `cortex_bucket_store_series_result_series` #5239 | |||
There was a problem hiding this comment.
Should we move this change into master / unreleased section?
Once this is merged, I will add this commit for our new RC
Signed-off-by: Friedrich Gonzalez <[email protected]>
yeya24
pushed a commit
to yeya24/cortex
that referenced
this pull request
Mar 31, 2023
…ect#5239) * Convert following metrics from summary to histogram cortex_bucket_store_series_blocks_queried cortex_bucket_store_series_data_fetched cortex_bucket_store_series_data_size_touched_bytes cortex_bucket_store_series_data_size_fetched_bytes cortex_bucket_store_series_data_touched cortex_bucket_store_series_result_series Signed-off-by: Friedrich Gonzalez <[email protected]> * Update changelog Signed-off-by: Friedrich Gonzalez <[email protected]> * fix changelog Signed-off-by: Friedrich Gonzalez <[email protected]> --------- Signed-off-by: Friedrich Gonzalez <[email protected]>
yeya24
pushed a commit
to yeya24/cortex
that referenced
this pull request
Mar 31, 2023
…ect#5239) * Convert following metrics from summary to histogram cortex_bucket_store_series_blocks_queried cortex_bucket_store_series_data_fetched cortex_bucket_store_series_data_size_touched_bytes cortex_bucket_store_series_data_size_fetched_bytes cortex_bucket_store_series_data_touched cortex_bucket_store_series_result_series Signed-off-by: Friedrich Gonzalez <[email protected]> * Update changelog Signed-off-by: Friedrich Gonzalez <[email protected]> * fix changelog Signed-off-by: Friedrich Gonzalez <[email protected]> --------- Signed-off-by: Friedrich Gonzalez <[email protected]> Signed-off-by: Ben Ye <[email protected]>
yeya24
added a commit
that referenced
this pull request
Apr 1, 2023
* Batch Iterator optimization (#5237) * Batch Opmization Signed-off-by: Alan Protasio <[email protected]> * Add test bacj Signed-off-by: Alan Protasio <[email protected]> * Testing Multiples scrape intervals Signed-off-by: Alan Protasio <[email protected]> * no assimption Signed-off-by: Alan Protasio <[email protected]> * Using max chunk ts Signed-off-by: Alan Protasio <[email protected]> * test with scrape 10 Signed-off-by: Alan Protasio <[email protected]> * rename method Signed-off-by: Alan Protasio <[email protected]> * comments Signed-off-by: Alan Protasio <[email protected]> * using next Signed-off-by: Alan Protasio <[email protected]> * change test name Signed-off-by: Alan Protasio <[email protected]> * changelog/comments Signed-off-by: Alan Protasio <[email protected]> --------- Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Ben Ye <[email protected]> * Store Gateway: Convert metrics from summary to histograms (#5239) * Convert following metrics from summary to histogram cortex_bucket_store_series_blocks_queried cortex_bucket_store_series_data_fetched cortex_bucket_store_series_data_size_touched_bytes cortex_bucket_store_series_data_size_fetched_bytes cortex_bucket_store_series_data_touched cortex_bucket_store_series_result_series Signed-off-by: Friedrich Gonzalez <[email protected]> * Update changelog Signed-off-by: Friedrich Gonzalez <[email protected]> * fix changelog Signed-off-by: Friedrich Gonzalez <[email protected]> --------- Signed-off-by: Friedrich Gonzalez <[email protected]> Signed-off-by: Ben Ye <[email protected]> * update changelog Signed-off-by: Ben Ye <[email protected]> * Catch context error in the s3 bucket client (#5240) Signed-off-by: Xiaochao Dong (@damnever) <[email protected]> Signed-off-by: Ben Ye <[email protected]> * bump RC version Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Friedrich Gonzalez <[email protected]> Signed-off-by: Xiaochao Dong (@damnever) <[email protected]> Co-authored-by: Alan Protasio <[email protected]> Co-authored-by: Friedrich Gonzalez <[email protected]> Co-authored-by: Xiaochao Dong <[email protected]>
friedrichg
added a commit
that referenced
this pull request
Apr 23, 2023
* prepare 1.15.0-rc release (#5235) Signed-off-by: Ben Ye <[email protected]> * Cherry-pick fixes to release 1.15 branch (#5241) * Batch Iterator optimization (#5237) * Batch Opmization Signed-off-by: Alan Protasio <[email protected]> * Add test bacj Signed-off-by: Alan Protasio <[email protected]> * Testing Multiples scrape intervals Signed-off-by: Alan Protasio <[email protected]> * no assimption Signed-off-by: Alan Protasio <[email protected]> * Using max chunk ts Signed-off-by: Alan Protasio <[email protected]> * test with scrape 10 Signed-off-by: Alan Protasio <[email protected]> * rename method Signed-off-by: Alan Protasio <[email protected]> * comments Signed-off-by: Alan Protasio <[email protected]> * using next Signed-off-by: Alan Protasio <[email protected]> * change test name Signed-off-by: Alan Protasio <[email protected]> * changelog/comments Signed-off-by: Alan Protasio <[email protected]> --------- Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Ben Ye <[email protected]> * Store Gateway: Convert metrics from summary to histograms (#5239) * Convert following metrics from summary to histogram cortex_bucket_store_series_blocks_queried cortex_bucket_store_series_data_fetched cortex_bucket_store_series_data_size_touched_bytes cortex_bucket_store_series_data_size_fetched_bytes cortex_bucket_store_series_data_touched cortex_bucket_store_series_result_series Signed-off-by: Friedrich Gonzalez <[email protected]> * Update changelog Signed-off-by: Friedrich Gonzalez <[email protected]> * fix changelog Signed-off-by: Friedrich Gonzalez <[email protected]> --------- Signed-off-by: Friedrich Gonzalez <[email protected]> Signed-off-by: Ben Ye <[email protected]> * update changelog Signed-off-by: Ben Ye <[email protected]> * Catch context error in the s3 bucket client (#5240) Signed-off-by: Xiaochao Dong (@damnever) <[email protected]> Signed-off-by: Ben Ye <[email protected]> * bump RC version Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Friedrich Gonzalez <[email protected]> Signed-off-by: Xiaochao Dong (@damnever) <[email protected]> Co-authored-by: Alan Protasio <[email protected]> Co-authored-by: Friedrich Gonzalez <[email protected]> Co-authored-by: Xiaochao Dong <[email protected]> * Cherry-pick fixes to release 1.15 for new RC (#5259) * fix remote read error in query frontend (#5257) * fix remote read error in query frontend Signed-off-by: Ben Ye <[email protected]> * fix integration test Signed-off-by: Ben Ye <[email protected]> * add extra one query Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> * bump RC version Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> * Fix splitByInterval incorrect error response format (#5260) (#5261) * fix query frontend incorrect error response format * update changelog * fix integration test --------- Signed-off-by: Ben Ye <[email protected]> * release 1.15.0 (#5274) Signed-off-by: Ben Ye <[email protected]> * merge 1.15 into master and resolve changelog conflicts Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Friedrich Gonzalez <[email protected]> Signed-off-by: Xiaochao Dong (@damnever) <[email protected]> Co-authored-by: Alan Protasio <[email protected]> Co-authored-by: Friedrich Gonzalez <[email protected]> Co-authored-by: Xiaochao Dong <[email protected]>
yeya24
pushed a commit
to yeya24/cortex
that referenced
this pull request
Apr 28, 2023
…ect#5239) * Convert following metrics from summary to histogram cortex_bucket_store_series_blocks_queried cortex_bucket_store_series_data_fetched cortex_bucket_store_series_data_size_touched_bytes cortex_bucket_store_series_data_size_fetched_bytes cortex_bucket_store_series_data_touched cortex_bucket_store_series_result_series Signed-off-by: Friedrich Gonzalez <[email protected]> * Update changelog Signed-off-by: Friedrich Gonzalez <[email protected]> * fix changelog Signed-off-by: Friedrich Gonzalez <[email protected]> --------- Signed-off-by: Friedrich Gonzalez <[email protected]> Signed-off-by: Ben Ye <[email protected]>
yeya24
added a commit
to yeya24/cortex
that referenced
this pull request
Apr 28, 2023
* prepare 1.15.0-rc release (cortexproject#5235) Signed-off-by: Ben Ye <[email protected]> * Cherry-pick fixes to release 1.15 branch (cortexproject#5241) * Batch Iterator optimization (cortexproject#5237) * Batch Opmization Signed-off-by: Alan Protasio <[email protected]> * Add test bacj Signed-off-by: Alan Protasio <[email protected]> * Testing Multiples scrape intervals Signed-off-by: Alan Protasio <[email protected]> * no assimption Signed-off-by: Alan Protasio <[email protected]> * Using max chunk ts Signed-off-by: Alan Protasio <[email protected]> * test with scrape 10 Signed-off-by: Alan Protasio <[email protected]> * rename method Signed-off-by: Alan Protasio <[email protected]> * comments Signed-off-by: Alan Protasio <[email protected]> * using next Signed-off-by: Alan Protasio <[email protected]> * change test name Signed-off-by: Alan Protasio <[email protected]> * changelog/comments Signed-off-by: Alan Protasio <[email protected]> --------- Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Ben Ye <[email protected]> * Store Gateway: Convert metrics from summary to histograms (cortexproject#5239) * Convert following metrics from summary to histogram cortex_bucket_store_series_blocks_queried cortex_bucket_store_series_data_fetched cortex_bucket_store_series_data_size_touched_bytes cortex_bucket_store_series_data_size_fetched_bytes cortex_bucket_store_series_data_touched cortex_bucket_store_series_result_series Signed-off-by: Friedrich Gonzalez <[email protected]> * Update changelog Signed-off-by: Friedrich Gonzalez <[email protected]> * fix changelog Signed-off-by: Friedrich Gonzalez <[email protected]> --------- Signed-off-by: Friedrich Gonzalez <[email protected]> Signed-off-by: Ben Ye <[email protected]> * update changelog Signed-off-by: Ben Ye <[email protected]> * Catch context error in the s3 bucket client (cortexproject#5240) Signed-off-by: Xiaochao Dong (@damnever) <[email protected]> Signed-off-by: Ben Ye <[email protected]> * bump RC version Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Friedrich Gonzalez <[email protected]> Signed-off-by: Xiaochao Dong (@damnever) <[email protected]> Co-authored-by: Alan Protasio <[email protected]> Co-authored-by: Friedrich Gonzalez <[email protected]> Co-authored-by: Xiaochao Dong <[email protected]> * Cherry-pick fixes to release 1.15 for new RC (cortexproject#5259) * fix remote read error in query frontend (cortexproject#5257) * fix remote read error in query frontend Signed-off-by: Ben Ye <[email protected]> * fix integration test Signed-off-by: Ben Ye <[email protected]> * add extra one query Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> * bump RC version Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> * Fix splitByInterval incorrect error response format (cortexproject#5260) (cortexproject#5261) * fix query frontend incorrect error response format * update changelog * fix integration test --------- Signed-off-by: Ben Ye <[email protected]> * release 1.15.0 (cortexproject#5274) Signed-off-by: Ben Ye <[email protected]> * merge 1.15 into master and resolve changelog conflicts Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Friedrich Gonzalez <[email protected]> Signed-off-by: Xiaochao Dong (@damnever) <[email protected]> Co-authored-by: Alan Protasio <[email protected]> Co-authored-by: Friedrich Gonzalez <[email protected]> Co-authored-by: Xiaochao Dong <[email protected]>
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
…ect#5239) * Convert following metrics from summary to histogram cortex_bucket_store_series_blocks_queried cortex_bucket_store_series_data_fetched cortex_bucket_store_series_data_size_touched_bytes cortex_bucket_store_series_data_size_fetched_bytes cortex_bucket_store_series_data_touched cortex_bucket_store_series_result_series Signed-off-by: Friedrich Gonzalez <[email protected]> * Update changelog Signed-off-by: Friedrich Gonzalez <[email protected]> * fix changelog Signed-off-by: Friedrich Gonzalez <[email protected]> --------- Signed-off-by: Friedrich Gonzalez <[email protected]> Signed-off-by: Alex Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Following metrics were updated in thanos from summary to histogram.
cortex_bucket_store_series_blocks_queried
cortex_bucket_store_series_data_fetched
cortex_bucket_store_series_data_size_touched_bytes
cortex_bucket_store_series_data_size_fetched_bytes
cortex_bucket_store_series_data_touched
cortex_bucket_store_series_result_series
Which issue(s) this PR fixes:
Fixes #5216
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]