Introduce OmitOperation #1
Conversation
- Reintroduce old JsonPatch.fromJson API - RegistryBasedJsonPatchFactory - Don't default operations upon construction of RegistryBasedJsonPatchFactoryBuilder - Rename RFC6902* -> Standard* - Other minor changes
…ended functionality: - Fixed bug where defaultFactory wasn't initialized - Added extendedFactory - Tests for the above
| @@ -123,11 +123,9 @@ public JsonPatch(final List<JsonPatchOperation> operations) | |||
| * @throws NullPointerException input is null | |||
| */ | |||
| public static JsonPatch fromJson(final JsonNode node) | |||
| throws IOException | |||
| { | |||
| throws IOException, JsonPatchException { | |||
There was a problem hiding this comment.
this smells, usually you have one exception type coming out and either wrap the IOException or don't return a more specifically typed one.
There was a problem hiding this comment.
Sounds good. JsonProcessingException extends IOException, so that will be handled as well.
- Created *OperationFactory classes - Minor style changes - made some things final
| * The JsonPatchOperationFactoryBase implements a few common operations | ||
| * for all JsonPatchOperationFactorys. | ||
| */ | ||
| public abstract class JsonPatchOperationFactoryBase implements JsonPatchOperationFactory |
There was a problem hiding this comment.
I'd be tempted to do this as a Helper instead of a Base.
|
Looks mostly good to me. Anyway you can fix the JsonPatchOperation interface thing and then get this patchset rebased on top of head (to eliminate my grails changes) so I can do a quick scan through? |
… specification of operation names
|
Pushed final review changes. Going to rebase and squash (maybe push it to a different PR rather than force push so we keep this history) |
|
Merged change up here: #2 |
Adding a public accessor to JsonPatch to retrieve the contained operation and path
No description provided.