Introduce OmitOperation #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code review changes: - Reintroduce old JsonPatch.fromJson API - RegistryBasedJsonPatchFactory - Don't default operations upon construction of RegistryBasedJsonPatchFactoryBuilder - Rename RFC6902* -> Standard* - Other minor changes Made a few changes to help a client easily integrate with the new extended functionality: - Fixed bug where defaultFactory wasn't initialized - Added extendedFactory - Tests for the above More code review changes: - Created *OperationFactory classes - Minor style changes - made some things final Converted JsonPatchOperation to interface, and got rid of a duplicate specification of operation names
Closed
| @@ -25,7 +25,7 @@ apply(plugin: "idea"); | |||
| apply(plugin: "eclipse"); | |||
|
|
|||
| group = "com.box"; | |||
| version = "1.10"; | |||
| version = "1.11"; | |||
There was a problem hiding this comment.
I'd usually do this as part of a separate release bump, but it's fine.
box-ehuang
added a commit
that referenced
this pull request
Jun 22, 2016
Hieu Nguyen (10):
Missed an OPERATION_NAME replace in CopyOperation
Add omit? operation and refactor packages
Removing the JsonPatchOperationFactory and just using TypeInfo annotation mixins for jackson deserialization/serialization
Remove annotations and instead introduce a ExtendedJsonPatch and ExtendedJsonPatchOperation
Add factory methods for mappers that can deserialize standard and extended JSON patch operations
Remove ExtendedJsonPatchOperation
Remove JsonSubTypes annotations on JsonPatchOperation (because we are using registerSubtypes)
Code review changes
Creating a Standard and Extended JsonPatchFactory that houses the ObjectMapper
Set version to 1.12
hnguyen08 (3):
Merge pull request #2 from hnguyen08/omit_merged
Merge pull request #3 from hnguyen08/omit_optional_operation
Merge pull request #6 from hnguyen08/remove_factories_and_support_deserialization
Add missing notes for versions 1.10, 1.11, 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review changes:
Made a few changes to help a client easily integrate with the new extended functionality:
More code review changes:
Converted JsonPatchOperation to interface, and got rid of a duplicate specification of operation names