Skip to content

Support take every instance of token transformation #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pokey opened this issue Jun 27, 2021 · 1 comment
Closed

Support take every instance of token transformation #29

pokey opened this issue Jun 27, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@pokey
Copy link
Member

pokey commented Jun 27, 2021

  • Do we also want to support taking a certain number of instances?
  • Also support narrowing to instances which appear within another target, eg "take every token fine in class gust"
  • Also support narrowing to instances that appear at the beginning of the line (what would syntax be?)
@brxck
Copy link
Collaborator

brxck commented Jun 27, 2021

All of these are something I find myself doing pretty often (though less so when I remember Rename Symbol is a thing), so I would definitely find them useful.

@pokey pokey added the enhancement New feature or request label Jan 12, 2022
@pokey pokey closed this as completed in 0ff8b93 May 26, 2023
cursorless-bot pushed a commit that referenced this issue May 26, 2023
- Implements the "instance" pseudo-scope. It functions grammatical kind
of like a scope, but hoists over ranges and uses its input in its own
way.
- Fixes #29
- Depends on #1496
- See #1490 for some discussion of how we got to this implementation

## Checklist

- [x] Handle word scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] Merge with #1496 ?
- [x] check performance on gigantic file
- [x] Come up with story around repeater noises. Maybe interact with
some new knausj quick actions interface, where "instance" establishes
that the "forward" quick action will perform action on additional target
- [x] Document how to add one more selection somewhere: "take that and
next instance that"
- [x] Capture writing from #1490
- [x] "first three instances"
- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] Handle narrowing range by selection
- [x] I have not broken the cheatsheet
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this issue Mar 27, 2024
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this issue Mar 27, 2024
- Implements the "instance" pseudo-scope. It functions grammatical kind
of like a scope, but hoists over ranges and uses its input in its own
way.
- Fixes cursorless-dev#29
- Depends on cursorless-dev#1496
- See cursorless-dev#1490 for some discussion of how we got to this implementation

## Checklist

- [x] Handle word scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] Merge with cursorless-dev#1496 ?
- [x] check performance on gigantic file
- [x] Come up with story around repeater noises. Maybe interact with
some new knausj quick actions interface, where "instance" establishes
that the "forward" quick action will perform action on additional target
- [x] Document how to add one more selection somewhere: "take that and
next instance that"
- [x] Capture writing from cursorless-dev#1490
- [x] "first three instances"
- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] Handle narrowing range by selection
- [x] I have not broken the cheatsheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants