Skip to content

Support "instance" pseudo-scope #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 26, 2023
Merged

Support "instance" pseudo-scope #1497

merged 5 commits into from
May 26, 2023

Conversation

pokey
Copy link
Member

@pokey pokey commented May 24, 2023 •
edited
Loading

Checklist

  • Handle word scopes
  • I have updated the docs and cheatsheet
  • Merge with Add isToken property to Target #1496 ?
  • check performance on gigantic file
  • Come up with story around repeater noises. Maybe interact with some new knausj quick actions interface, where "instance" establishes that the "forward" quick action will perform action on additional target
  • Document how to add one more selection somewhere: "take that and next instance that"
  • Capture writing from Support "instance" scope type #1490
  • "first three instances"
  • I have added tests
  • Handle narrowing range by selection
  • I have not broken the cheatsheet

This was referenced May 24, 2023
Merged
Merged
@pokey pokey force-pushed the pokey/support-instance-pseudo-scopes branch 2 times, most recently from 7aea2f0 to 3110e99 Compare May 24, 2023 21:32
@pokey pokey changed the title Support "instance" pseudo-scopes Support "instance" pseudo-scope May 24, 2023
@pokey pokey force-pushed the pokey/add-istoken-property-to-target branch from 63b15ec to c821f7e Compare May 24, 2023 22:06
@pokey pokey force-pushed the pokey/support-instance-pseudo-scopes branch 3 times, most recently from b011135 to a4518d0 Compare May 25, 2023 08:03
@pokey pokey force-pushed the pokey/add-istoken-property-to-target branch from c821f7e to 7df90ed Compare May 25, 2023 08:58
@pokey pokey force-pushed the pokey/support-instance-pseudo-scopes branch 2 times, most recently from 6747dfc to fd88514 Compare May 25, 2023 10:55
@pokey pokey force-pushed the pokey/add-istoken-property-to-target branch from 599bfd3 to 84e631c Compare May 25, 2023 12:52
@pokey pokey force-pushed the pokey/support-instance-pseudo-scopes branch 5 times, most recently from 2ae3d8f to ff29304 Compare May 25, 2023 14:49
pokey
pokey commented May 25, 2023
View reviewed changes
...de-e2e/src/suite/fixtures/recorded/modifiers/instance/preEveryInstanceEveryCarAirPastBat.yml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if setSelection actions should sort the selections. I'm sure it would be unexpected to realise these cursors are in this haphazard order, esp since VSCode gives no visual indication of cursor order. Out of scope for this PR obv, but just a thought

@pokey pokey force-pushed the pokey/support-instance-pseudo-scopes branch 2 times, most recently from 1c70efa to 6cfd216 Compare May 25, 2023 15:20
@pokey pokey mentioned this pull request May 25, 2023
Closed
9 tasks
@pokey pokey requested a review from AndreasArvidsson May 25, 2023 15:28
@pokey pokey force-pushed the pokey/support-instance-pseudo-scopes branch from 6cfd216 to e77e7b4 Compare May 25, 2023 15:45
@pokey pokey force-pushed the pokey/support-instance-pseudo-scopes branch from e77e7b4 to 837db66 Compare May 26, 2023 08:03
@pokey pokey force-pushed the pokey/add-istoken-property-to-target branch from 660351a to fabd6e2 Compare May 26, 2023 08:03
pokey added a commit that referenced this pull request May 26, 2023
@pokey
Generalize "every" range hoisting code (#1495)
91ef761 
- Generalize the way we handle scope hoisting in preparation for
#1497
- Depends on #1494

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet
@pokey pokey force-pushed the pokey/support-instance-pseudo-scopes branch from 837db66 to 17f56db Compare May 26, 2023 08:41
@pokey pokey force-pushed the pokey/add-istoken-property-to-target branch from fabd6e2 to 09cd5c7 Compare May 26, 2023 08:41
pokey added a commit that referenced this pull request May 26, 2023
@pokey
Add isToken property to Target (#1496)
cb839ca 
- Primarily useful for
#1497
- Depends on #1495

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet
Base automatically changed from pokey/add-istoken-property-to-target to main May 26, 2023 09:30
@pokey pokey force-pushed the pokey/support-instance-pseudo-scopes branch from 17f56db to e046128 Compare May 26, 2023 09:56
@pokey pokey marked this pull request as ready for review May 26, 2023 09:56
@pokey pokey enabled auto-merge May 26, 2023 09:56
@pokey pokey added this pull request to the merge queue May 26, 2023
Merged via the queue into main with commit 0ff8b93 May 26, 2023
@pokey pokey deleted the pokey/support-instance-pseudo-scopes branch May 26, 2023 10:55
cursorless-bot pushed a commit that referenced this pull request May 26, 2023
@pokey
Support "instance" pseudo-scope (#1497)
5e0a244 
- Implements the "instance" pseudo-scope. It functions grammatical kind
of like a scope, but hoists over ranges and uses its input in its own
way.
- Fixes #29
- Depends on #1496
- See #1490 for some discussion of how we got to this implementation

## Checklist

- [x] Handle word scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] Merge with #1496 ?
- [x] check performance on gigantic file
- [x] Come up with story around repeater noises. Maybe interact with
some new knausj quick actions interface, where "instance" establishes
that the "forward" quick action will perform action on additional target
- [x] Document how to add one more selection somewhere: "take that and
next instance that"
- [x] Capture writing from #1490
- [x] "first three instances"
- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] Handle narrowing range by selection
- [x] I have not broken the cheatsheet
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this pull request Mar 27, 2024
@pokey @cursorless-bot
Support "instance" pseudo-scope (cursorless-dev#1497)
c6384da 
- Implements the "instance" pseudo-scope. It functions grammatical kind
of like a scope, but hoists over ranges and uses its input in its own
way.
- Fixes cursorless-dev#29
- Depends on cursorless-dev#1496
- See cursorless-dev#1490 for some discussion of how we got to this implementation

## Checklist

- [x] Handle word scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] Merge with cursorless-dev#1496 ?
- [x] check performance on gigantic file
- [x] Come up with story around repeater noises. Maybe interact with
some new knausj quick actions interface, where "instance" establishes
that the "forward" quick action will perform action on additional target
- [x] Document how to add one more selection somewhere: "take that and
next instance that"
- [x] Capture writing from cursorless-dev#1490
- [x] "first three instances"
- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] Handle narrowing range by selection
- [x] I have not broken the cheatsheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pokey @AndreasArvidsson