Skip to content

Within cell set selection fails non deterministically on ci #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndreasArvidsson opened this issue Jul 7, 2022 · 3 comments · Fixed by #870
Closed

Within cell set selection fails non deterministically on ci #845

AndreasArvidsson opened this issue Jul 7, 2022 · 3 comments · Fixed by #870
Assignees
Labels
code quality Improvements to code quality
Milestone

Comments

@AndreasArvidsson
Copy link
Member

Seems to happen only on windows

https://github.com/cursorless-dev/cursorless/runs/7238130016?check_suite_focus=true#step:6:2236

@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Jul 10, 2022

Now it started happening more on mac for some reason

@pokey Any idea why this started happening on ci?

@pokey
Copy link
Member

pokey commented Jul 10, 2022

Prob need to tweak a sleep

I had an idea for that. Maybe we should sleep more each time the test fails, rather than sleeping the same amount each time

We could have a special sleep function where you pass in the test name and the name of the sleep (each sleep will need a name). Then the sleep function will initially sleep 1/4 of the requested time and store that it has done that sleep once. Next time that test runs, if it failed, the sleep function will see it had slept once before and sleep half the requested time. Then whole time, etc. by the time it is 5th try it is sleeping 4x

WDYT?

@AndreasArvidsson
Copy link
Member Author

Incrementally increase sleep time is probably a good idea.

@pokey pokey added this to the 0.27.0 milestone Jul 10, 2022
@pokey pokey added the code quality Improvements to code quality label Jul 12, 2022
@pokey pokey self-assigned this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvements to code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants